Conversation
The recently added code for supporting sparse mmap areas in the Server had assumed that a file descriptor was attached to each area. This is not correct, as the specification expects a single file descriptor backing the entire region (one fd per region). And the list of sparse mmap areas corresponds to a list of offset/size that can be mapped within this backing file. Signed-off-by: Sebastien Boeuf <sboeuf@meta.com>
sboeuf
requested review from
jiangliu,
jinankjain,
likebreath,
liuw,
rbradford,
russell-islam and
sameo
as code owners
Adding the Clone implementation to IrqInfo, ServerRegion and SparseArea will allow the consumer of the Server to build these in advance if needed. Signed-off-by: Sebastien Boeuf <sboeuf@meta.com>
|
@likebreath could you please give this a quick review? |
|
thank you @likebreath :) |
@sboeuf You bet. I think once all the fixes you need are landed for vfio-user, we should prepare a release for the vfio-{user,ioctl,bindings} crates, so that we can consume them from Cloud Hypervisor side. (I believe the heavy-lifting will be bumping all rust-vmm crates.) What do you think? |
Yes I agree! A release will be nice, but let's wait a few weeks just in case something else is needed. |
3 participants
The recently added code for supporting sparse mmap areas in the Server had assumed that a file descriptor was attached to each area. This is not correct, as the specification expects a single file descriptor backing the entire region (one fd per region). And the list of sparse mmap areas corresponds to a list of offset/size that can be mapped within this backing file.