Implement revamped RedrawRequested on Web#1301
Merged
ryanisaacg merged 2 commits intorust-windowing:redraw-requested-2.0from Dec 3, 2019
Merged
Implement revamped RedrawRequested on Web#1301ryanisaacg merged 2 commits intorust-windowing:redraw-requested-2.0from
RedrawRequested on Web#1301ryanisaacg merged 2 commits intorust-windowing:redraw-requested-2.0from
Conversation
hecrj
changed the title
RedrawRequested on Web
hecrj
force-pushed
the
web-redraw-requested-2.0
branch
from
2a87caa to
59691b0
Compare
simlay
reviewed
Dec 2, 2019
| [dev-dependencies] | ||
| image = "0.21" | ||
| env_logger = "0.5" | ||
| console_log = "0.1" |
Contributor
There was a problem hiding this comment.
I think it might be good to do to target.'cfg(target_arch = "wasm32")'.dev-dependencies] and maybe even with the sys-web feature flag but I don't feel too strongly about it.
Contributor
Author
There was a problem hiding this comment.
IIRC, it's not possible to check enabled features in the Cargo manifest.
In any case, I have changed it to only enable console_log when targetting wasm32. Thanks for the catch.
hecrj
force-pushed
the
web-redraw-requested-2.0
branch
from
59691b0 to
1d082db
Compare
Osspial
approved these changes
Dec 2, 2019
Contributor
Osspial
left a comment
Osspial
left a comment
There was a problem hiding this comment.
I've tested this out, and it seems to work swimmingly. Unless anyone else sees any outstanding issues, this should be good to merge!
10 tasks
ryanisaacg
approved these changes
Dec 3, 2019
Osspial
pushed a commit
that referenced
this pull request
Dec 22, 2019
* Implement revamped `RedrawRequested` on Web * Add `web` example
Osspial
pushed a commit
that referenced
this pull request
Dec 22, 2019
* Implement revamped `RedrawRequested` on Web * Add `web` example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1082.
I figured I would give this a shot and it was easier than I expected. Once this and #1299 are merged, I think #1082 will be ready to go!
I have also added a
webexample to test things out. It seems to work fine.cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users