Conversation
#1589 shipped `drive sheets` CLI-first with MCP tools deferred per ADR-0073 §12. Adds the read-only half of that surface, mirroring `drive_file_read`'s shape: both tools delegate to the same engine functions the CLI uses and return YAML. The write verbs (write/ append/clear) stay deferred pending their own dry-run-equivalent and refusal-surfacing design.
CoverageTotal: 97.08% ⚪ 0 pp vs Comparing
Patch coveragePatch: 95.9% (257/268 new lines covered)
Uncovered new lines (11)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drive_sheets_infoanddrive_sheets_readMCP tools tosrc/mcp/drive_tools.rs, closing feat(mcp): expose the drive sheets surface as MCP tools #1614's suggested first pass — mirrorsdrive_file_read's shape and delegates to the same engine functions the CLI'sdrive sheets info/readalready use (SheetsApi::get_spreadsheet,sheets::read::read), returning YAML.write/append/clear) remain deferred, per the issue's own scoping (dry-run equivalent andRefusedNoVisibleParentssurfacing still need their own design).(mirrors the \drive_sheets_info`/`drive_sheets_read` MCP tool)cross-reference to the CLI'ssheets info/readsubcommand help (STYLE-0029), and updatesdocs/mcp.md+CHANGELOG.md` accordingly.Test plan
cargo test(default features, all 9 test binaries) — 8,732 tests passcargo test --features mcp --test mcp_integration_test— 44 tests passcargo clippy --all-features --all-targets -- -D warnings— cleancargo fmt --check— cleanupdate-snapshotsskill run;instasnapshot diff reviewed and accepted (only the two new CLI help cross-references changed)daemon_test.rs's two SIGHUP/shutdown lifecycle tests failed in the full local run — this is a known, pre-existing load-sensitive flake unrelated to this change (no daemon code touched)Refs #1589, ADR-0073 §12