fix(drive): skip property-less sheets in has_sheet_titled - #1704
Merged
Merged
Conversation
CoverageTotal: 97.28% ⚪ 0 pp vs Comparing
🔇 5 ignored region(s), 0 tolerated region(s)
Patch coveragePatch: 100% (13/13 new lines covered)
|
newhoggy
force-pushed
the
issue-1702-sheet-title-property-less
branch
from
September 17, 2026 15:01
1aa6392 to
848d954
Compare
Spreadsheet::has_sheet_titled compared against Sheet::title(), which maps a sheet with absent properties to "" — coercing it into a false collision with an explicit empty-title request. The hand-written loops this helper replaced in structure.rs::resolve_sheet instead skip property-less sheets entirely via filter_map(properties.as_ref()). Restore that behavior and add a regression test. Fixes #1702
newhoggy
force-pushed
the
issue-1702-sheet-title-property-less
branch
from
September 17, 2026 15:50
848d954 to
e809a28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spreadsheet::has_sheet_titledcompared againstSheet::title(), which coerces a sheet with absentpropertiesto"", causing a false collision with an explicit empty-title request.filter_map(properties.as_ref()), matchingstructure.rs::resolve_sheet's hand-written check) so property-less sheets are skipped, not coerced.Fixes #1702
Test plan
cargo test --lib drive::sheets::types— 13 passed, including the newhas_sheet_titled_skips_a_property_less_sheetcargo clippy -- -D warningscargo fmt --check