Skip to content

docs(docs,request-log): fix stale post-lease-work claims - #1721

Merged
newhoggy merged 2 commits into
mainfrom
issue-1698-drive-docs-stale-claims
Sep 17, 2026
Merged

newhoggy merged 2 commits into
mainfrom
issue-1698-drive-docs-stale-claims

Conversation

@newhoggy

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • cargo build
  • cargo test --lib request_log:: (92 passed)
  • cargo clippy --all-targets -- -D warnings
  • Verified the OMNI_DEV_LOG_DISABLE exemption claim against the code directly — confirmed accurate, including a dedicated existing test (record_audit_is_exempt_from_omni_dev_log_disable)

Four documentation statements were made stale by the ADR-0080 drive
write-lease work (4c7185c^..fe55042): `drive lease restore` no
longer only *locates* a single deleted sheet's backup copy (it
restores it automatically via `spreadsheets.sheets.copyTo`), a trash
capability now exists (`FilesApi::trash`, exercised by `drive lease
prune`), `drive lease restore` is in fact an undo path, and
`OMNI_DEV_LOG_DISABLE` is an absolute opt-out only for `log.jsonl`,
not the fail-closed `audit.jsonl` sink.

- docs/drive.md: correct the capability inventory and the
  delete-sheet recovery section's restore/undo claims.
- CHANGELOG.md: correct the same restore/undo claims in the
  `[Unreleased]` restore and delete-sheet bullets, and add the
  missing `drive lease prune` (#1678) entry.
- CLAUDE.md, src/request_log.rs: scope the `OMNI_DEV_LOG_DISABLE`
  claim to `log.jsonl` and note the audit-sink exemption.
Grammar fix from the previous commit's edit — "into the live
spreadsheet still a manual" was missing "is".
@github-actions

Copy link
Copy Markdown

Coverage

Total: 97.27% ⚪ 0 pp vs main

Comparing 6ea732b..9cb18c2 (merge-base → PR head)

No per-file coverage changes vs main.

🔇 5 ignored region(s), 0 tolerated region(s)

ignore removes the lines from both reports; tolerate keeps them in the reported percentage but scores them against the baseline, so a cross-run flip cannot move a delta. Regions are read from each revision's own source.

File Kind Lines Rev Reason
src/cli/drive/lease.rs ignore 418-422 both a sheet restore's fresh backup is always a DriveCopy — restore.rs's own recheck refuses unless the target is still a spreadsheet, and acquire() only ever takes a Bytes backup of a non-native target; this arm exists solely for exhaustiveness over the shared LeaseBackup enum
src/cli/drive/lease.rs ignore 1000-1003 both guards this test helper against misuse; every call site below passes an acquire subcommand
src/cli/drive/lease.rs ignore 1014-1017 both guards this test helper against misuse; every call site below passes a prune subcommand
src/drive/lease/ledger.rs ignore 812-816 both mutate_locked refuses before ever calling the closure, so its body never runs — a hit here is a regression, not a coverage gap
src/drive/lease/restore.rs ignore 1137-1141 both every test using this double refuses before authenticating; a hit here is a regression, not a coverage gap

Patch coverage

No new executable lines added by this diff.

📦 Full per-file coverage summary · run summary

@newhoggy
newhoggy merged commit d112f5b into main Sep 17, 2026
17 checks passed
@newhoggy
newhoggy deleted the issue-1698-drive-docs-stale-claims branch September 17, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(drive,docs): four stale claims after the lease work (no-undo, no-trash, restore only locates, LOG_DISABLE absolute)

1 participant