docs(docs,request-log): fix stale post-lease-work claims - #1721
Merged
Merged
Conversation
Four documentation statements were made stale by the ADR-0080 drive write-lease work (4c7185c^..fe55042): `drive lease restore` no longer only *locates* a single deleted sheet's backup copy (it restores it automatically via `spreadsheets.sheets.copyTo`), a trash capability now exists (`FilesApi::trash`, exercised by `drive lease prune`), `drive lease restore` is in fact an undo path, and `OMNI_DEV_LOG_DISABLE` is an absolute opt-out only for `log.jsonl`, not the fail-closed `audit.jsonl` sink. - docs/drive.md: correct the capability inventory and the delete-sheet recovery section's restore/undo claims. - CHANGELOG.md: correct the same restore/undo claims in the `[Unreleased]` restore and delete-sheet bullets, and add the missing `drive lease prune` (#1678) entry. - CLAUDE.md, src/request_log.rs: scope the `OMNI_DEV_LOG_DISABLE` claim to `log.jsonl` and note the audit-sink exemption.
Grammar fix from the previous commit's edit — "into the live spreadsheet still a manual" was missing "is".
CoverageTotal: 97.27% ⚪ 0 pp vs Comparing No per-file coverage changes vs 🔇 5 ignored region(s), 0 tolerated region(s)
Patch coverageNo new executable lines added by this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drive lease restore/prunephases (e.g. "no typed restore path yet" after the typed path landed, "nofiles.deleteor undo" afterrestoreadded a partial undo).Test plan
cargo buildcargo test --lib request_log::(92 passed)cargo clippy --all-targets -- -D warningsOMNI_DEV_LOG_DISABLEexemption claim against the code directly — confirmed accurate, including a dedicated existing test (record_audit_is_exempt_from_omni_dev_log_disable)