Skip to content

chore(cargo,mcp): bump rmcp to 3.4.0, fix deprecated ServerInfo usage - #1722

Merged
newhoggy merged 1 commit into
mainfrom
fix-mcp-server-config-deprecation
Sep 18, 2026
Merged

newhoggy merged 1 commit into
mainfrom
fix-mcp-server-config-deprecation

Conversation

@newhoggy

Copy link
Copy Markdown
Contributor

Summary

  • Bump rmcp from 3.3.0 to 3.4.0, which introduces model::ServerConfig as the replacement for the deprecated model::ServerInfo type alias.
  • Switch OmniDevServer::get_info in src/mcp/server.rs to use ServerConfig (same underlying InitializeResult type), clearing all 3 #[warn(deprecated)] warnings.

Test plan

  • cargo build --features mcp --lib — clean, no warnings
  • cargo clippy --features mcp --lib -- -D warnings — clean
  • cargo test --features mcp --lib mcp:: — 790 passed, 0 failed

rmcp 3.4.0 deprecates the `model::ServerInfo` type alias in favor of
`ServerConfig` (same underlying `InitializeResult` type). Bump the pinned
version and switch `OmniDevServer::get_info` over to silence the three
resulting `#[warn(deprecated)]` warnings.
@github-actions

Copy link
Copy Markdown

Coverage

Total: 97.27% ⚪ 0 pp vs main

Comparing d112f5b..b8bf9e2 (merge-base → PR head)

No per-file coverage changes vs main.

🔇 5 ignored region(s), 0 tolerated region(s)

ignore removes the lines from both reports; tolerate keeps them in the reported percentage but scores them against the baseline, so a cross-run flip cannot move a delta. Regions are read from each revision's own source.

File Kind Lines Rev Reason
src/cli/drive/lease.rs ignore 418-422 both a sheet restore's fresh backup is always a DriveCopy — restore.rs's own recheck refuses unless the target is still a spreadsheet, and acquire() only ever takes a Bytes backup of a non-native target; this arm exists solely for exhaustiveness over the shared LeaseBackup enum
src/cli/drive/lease.rs ignore 1000-1003 both guards this test helper against misuse; every call site below passes an acquire subcommand
src/cli/drive/lease.rs ignore 1014-1017 both guards this test helper against misuse; every call site below passes a prune subcommand
src/drive/lease/ledger.rs ignore 812-816 both mutate_locked refuses before ever calling the closure, so its body never runs — a hit here is a regression, not a coverage gap
src/drive/lease/restore.rs ignore 1137-1141 both every test using this double refuses before authenticating; a hit here is a regression, not a coverage gap

Patch coverage

Patch: 100% (2/2 new lines covered)

File Patch Uncovered new lines
src/mcp/server.rs 100% (2/2)

📦 Full per-file coverage summary · run summary

@newhoggy
newhoggy merged commit b6a9c68 into main Sep 18, 2026
17 checks passed
@newhoggy
newhoggy deleted the fix-mcp-server-config-deprecation branch September 18, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant