feat: pool CEL validation, tenant DNS cap, deploy tooling, Cursor skill#101
Merged
GatewayJ merged 1 commit intorustfs:mainfrom Mar 28, 2026
Merged
feat: pool CEL validation, tenant DNS cap, deploy tooling, Cursor skill#101GatewayJ merged 1 commit intorustfs:mainfrom
GatewayJ merged 1 commit intorustfs:mainfrom
Conversation
- Align Pool CRD CEL with console API (min volumes + 3-server rule); validate_pool_total_volumes + tests; regen CRDs - Cap Tenant metadata.name at 55 chars for derived Service names (-console) - Deploy scripts: docker_build_cached, RUSTFS_DOCKER_NO_CACHE; 4-node help/sudo cleanup - Dockerfiles: cargo-chef pin / frontend image tweaks - Add .cursor/skills/rustfs-operator-contribute for commit/PR workflow; adjust .gitignore for skills - CHANGELOG, README, examples, scripts docs Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
N/A
Summary of Changes
This PR tightens Tenant Pool validation at the CRD layer (CEL) to match the operator console API, caps Tenant
metadata.namelength so derived Service names stay within DNS limits, improves deploy/cleanup scripts (Docker layer cache by default, sudo for host storage cleanup, 4-node help/shell robustness), Dockerfile build caching, and adds a Cursor project skill (rustfs-operator-contribute) plus.gitignorerules so.cursor/skills/can be versioned.Pool / CRD
servers × volumesPerServer >= 4for all pools; additional rule forservers == 3requiring>= 6total volumes.validate_pool_total_volumesused by console handlers and unit tests; regenerateddeploy/rustfs-operator/crds/tenant-crd.yamlandtenant.yaml.Tenant name
validate_dns1035_label: max length 55 (longest derived label{name}-console+ 8 chars vs 63 limit).Scripts / Docker
docker_build_cached;RUSTFS_DOCKER_NO_CACHE=truefor clean rebuilds; documented inscripts/README.md.sudo rmfor Kind host paths when needed.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
Verification
make pre-commit cargo test --allAdditional Notes
.gitignorenow ignores.cursor/*except.cursor/skills/**so Agent skills can live in-repo.RUSTFS_DOCKER_NO_CACHE=true ./scripts/deploy/deploy-rustfs-4node.sh(ordeploy-rustfs.sh).Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.