feat: pool CEL validation, tenant DNS limits, KMS alignment, and tooling#102
Merged
GatewayJ merged 1 commit intorustfs:mainfrom Mar 29, 2026
Merged
feat: pool CEL validation, tenant DNS limits, KMS alignment, and tooling#102GatewayJ merged 1 commit intorustfs:mainfrom
GatewayJ merged 1 commit intorustfs:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
N/A
Summary of Changes
This PR bundles operator hardening and user-facing improvements:
Pool validation: Align CRD CEL rules and Rust
#[x_kube(validation)]with the console API — requireservers × volumesPerServer ≥ 4for every pool and≥ 6total volumes whenservers == 3(fixes incorrect 3-server CEL logic). Add sharedvalidate_pool_total_volumesinsrc/types/v1alpha1/pool.rswith unit tests; regeneratedeploy/rustfs-operator/crds/tenant-crd.yamlandtenant.yaml.Tenant naming: Enforce DNS-1035 rules and cap
metadata.nameat 55 characters so derived names such as{name}-consolestay within Kubernetes DNS label limits. Validate on reconcile and on console tenant creation; addInvalidTenantNameand 60s requeue for user-fixable errors.Encryption / KMS: Align injected pod environment variables with the RustFS server and
rustfs-kmsnaming (RUSTFS_KMS_ENABLE,RUSTFS_KMS_VAULT_ADDRESS, localRUSTFS_KMS_KEY_DIR/RUSTFS_KMS_DEFAULT_KEY_ID, etc.). RemovetlsSkipVerifyandcustomCertificatesfrom API, console UI, and types (they were not wired torustfs-kms). Runvalidate_kms_secretwheneverspec.encryption.enabledis true. Add Local KMS validation (absolutekeyDirectory, single replica across pools). Update CRD descriptions; reserveping_secondswithout injecting until supported.Tooling & docs: Expand root
README.md; deploy scripts use Docker layer cache by default (RUSTFS_DOCKER_NO_CACHEfor clean rebuild); Dockerfile improvements (cargo-chef pin, console-web pnpm pin). Add Cursor skill.cursor/skills/rustfs-operator-contributeand adjust.gitignoreto version skills.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
Breaking / migration: Remove
spec.encryption.vault.tlsSkipVerifyandcustomCertificatesfrom Tenant YAML if present. If you relied on per-encryptionsecurityContext, confirm the CRD layout in this branch (securityContextat Tenantspeclevel when applicable). SeeCHANGELOG.mdunder[Unreleased].Verification
Additional Notes
N/A
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.