Skip to content

fix(ui): smooth theme switch + filterable tag dropdown #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xsmyile merged 2 commits into from
Jun 16, 2026
Merged

fix(ui): smooth theme switch + filterable tag dropdown #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8388d8c
fix(ui): suppress transitions during theme switch
xsmyile Jun 16, 2026
40edd14
feat(ui): add filter input to tag dropdown past 8 tags
xsmyile Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 74 additions & 43 deletions ui/src/components/FilterBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import {
total,
} from "../stores/messages";

const TAG_SEARCH_THRESHOLD = 8;

function Chip(props: {
label: string;
active: boolean;
Expand Down Expand Up @@ -42,9 +44,16 @@ function Chip(props: {
function TagDropdown() {
const [open, setOpen] = createSignal(false);
const [pos, setPos] = createSignal({ top: 0, left: 0 });
const [tagQuery, setTagQuery] = createSignal("");
let triggerRef: HTMLButtonElement | undefined;
let dropdownRef: HTMLDivElement | undefined;

const visibleTags = () => {
const q = tagQuery().trim().toLowerCase();
const tags = allTags();
return q ? tags.filter((t) => t.toLowerCase().includes(q)) : tags;
};

function updatePosition() {
if (!triggerRef) return;
const rect = triggerRef.getBoundingClientRect();
Expand Down Expand Up @@ -74,6 +83,7 @@ function TagDropdown() {
open,
(isOpen) => {
if (isOpen) {
setTagQuery("");
updatePosition();
window.addEventListener("scroll", updatePosition, true);
window.addEventListener("resize", updatePosition);
Expand Down Expand Up @@ -157,51 +167,72 @@ function TagDropdown() {
</div>
}
>
<Show when={allTags().length > TAG_SEARCH_THRESHOLD}>
<div class="border-b border-zinc-100 dark:border-zinc-800 p-1.5">
<input
type="text"
ref={(el) => queueMicrotask(() => el.focus())}
value={tagQuery()}
onInput={(e) => setTagQuery(e.currentTarget.value)}
placeholder="Filter tags..."
class="w-full rounded-md border border-zinc-200 dark:border-zinc-700 bg-zinc-50 dark:bg-zinc-800/50 px-2 py-1 text-xs text-zinc-700 dark:text-zinc-300 placeholder-zinc-400 dark:placeholder-zinc-500 outline-none focus:border-zinc-400 dark:focus:border-zinc-600"
/>
</div>
</Show>
<div class="py-1">
<For each={allTags()}>
{(tag) => {
const isSelected = () => filters().tags.includes(tag);
return (
<button
onClick={() => toggleTagFilter(tag)}
class="flex items-center gap-2 w-full px-3 py-1.5 text-left text-xs hover:bg-zinc-50 dark:hover:bg-zinc-800 transition-colors cursor-pointer"
>
<div
class={`size-3.5 rounded border flex items-center justify-center transition-colors ${
isSelected()
? "bg-orange-500 border-orange-500"
: "border-zinc-300 dark:border-zinc-600"
}`}
>
<Show when={isSelected()}>
<svg
class="size-2.5 text-white"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
stroke-width="3"
>
<path
stroke-linecap="round"
stroke-linejoin="round"
d="M4.5 12.75l6 6 9-13.5"
/>
</svg>
</Show>
</div>
<span
class={
isSelected()
? "text-zinc-900 dark:text-zinc-100"
: "text-zinc-600 dark:text-zinc-400"
}
<Show
when={visibleTags().length > 0}
fallback={
<div class="px-3 py-3 text-xs text-zinc-400 dark:text-zinc-500 text-center">
No matching tags
</div>
}
>
<For each={visibleTags()}>
{(tag) => {
const isSelected = () => filters().tags.includes(tag);
return (
<button
onClick={() => toggleTagFilter(tag)}
class="flex items-center gap-2 w-full px-3 py-1.5 text-left text-xs hover:bg-zinc-50 dark:hover:bg-zinc-800 transition-colors cursor-pointer"
>
{tag}
</span>
</button>
);
}}
</For>
<div
class={`size-3.5 rounded border flex items-center justify-center transition-colors ${
isSelected()
? "bg-orange-500 border-orange-500"
: "border-zinc-300 dark:border-zinc-600"
}`}
>
<Show when={isSelected()}>
<svg
class="size-2.5 text-white"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
stroke-width="3"
>
<path
stroke-linecap="round"
stroke-linejoin="round"
d="M4.5 12.75l6 6 9-13.5"
/>
</svg>
</Show>
</div>
<span
class={
isSelected()
? "text-zinc-900 dark:text-zinc-100"
: "text-zinc-600 dark:text-zinc-400"
}
>
{tag}
</span>
</button>
);
}}
</For>
</Show>
</div>
<Show when={filters().tags.length > 0}>
<div class="border-t border-zinc-100 dark:border-zinc-800 px-3 py-1.5">
Expand Down
5 changes: 5 additions & 0 deletions ui/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
font-family: var(--font-brand);
}

.theme-switching,
.theme-switching * {
transition: none !important;
}

.mesh-glow {
position: fixed;
top: 0;
Expand Down
6 changes: 5 additions & 1 deletion ui/src/stores/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ function resolve(t: Theme): "dark" | "light" {
}

function applyTheme(t: Theme) {
document.documentElement.classList.toggle("dark", resolve(t) === "dark");
const root = document.documentElement;
root.classList.add("theme-switching");
root.classList.toggle("dark", resolve(t) === "dark");
void root.offsetHeight;
root.classList.remove("theme-switching");
}

applyTheme(theme());
Expand Down