fix(ui): make links in email HTML preview clickable#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Links in the HTML email preview (e.g. transactional "confirm email" buttons) were not clickable — the preview iframe used
sandbox="", which blocks all popups and navigation. Users were forced to copy/paste the fallback URL.Fix
sandbox="allow-popups allow-popups-to-escape-sandbox"sotarget="_blank"links open a working new tab.<base target="_blank">into the srcdoc so links without an explicit target also open in a new tab instead of navigating the tiny iframe in place.Security
allow-scripts— email HTML still cannot execute JavaScript (no XSS).allow-top-navigation*— email HTML cannot hijack/redirect the RustMail tab itself; only the new tab navigates.allow-popups-to-escape-sandbox— the link destination is a real JS app needing cookies/scripts; without escaping, the new tab would inherit the sandbox (opaque origin, no scripts) and load broken.Tested locally against the live backend via the Vite proxy: confirm button + fallback link open a new tab; inbox tab is not redirected.