Gta

.env.example

@@ -12,3 +12,4 @@ PRIVATE_KEY_FILE=
 PUBLIC_KEY_FILE=
 SENTRY_DSN=
 MCO_LOG_LEVEL=
+MCO_LOGGING_GROUPS=

.github/workflows/node.yml

@@ -5,15 +5,14 @@ on:
     pull_request:
     workflow_dispatch:
     merge_group:
-
 
 jobs:
     build-test:
         runs-on: ubuntu-latest
 
         strategy:
             matrix:
-                node-version: [20.x, 22.x, 23.x]
+                node-version: [22.x, 23.x, 24.x]
 
         steps:
             - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4

.vscode/extensions.json

@@ -1,10 +1,11 @@
 {
     "recommendations": [
-        "ms-azuretools.vscode-docker",
         "ms-vscode.makefile-tools",
         "usernamehw.errorlens",
-        "biomejs.biome",
-        "dbaeumer.vscode-eslint",
-        "esbenp.prettier-vscode"
+        "ms-azuretools.vscode-containers",
+        "kisstkondoros.vscode-codemetrics",
+        "mhutchie.git-graph",
+        "vitest.explorer",
+        "biomejs.biome"
     ]
 }

.vscode/launch.json

@@ -4,6 +4,23 @@
     // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
     "version": "0.2.0",
     "configurations": [
+        {
+            "name": "Typescript",
+            "type": "node",
+            "runtimeExecutable": "pnpx",
+            "runtimeVersion": "23.5.0",
+            "request": "launch",
+            "args": ["src/server.ts"],
+            "runtimeArgs": [
+                "tsx",
+                "--import",
+                "./instrument.mjs",
+                "--openssl-legacy-provider"
+            ],
+            "cwd": "${workspaceRoot}",
+            "envFile": "${workspaceFolder}/.env",
+            "internalConsoleOptions": "openOnSessionStart"
+        },
         {
             "name": "Stop Prod",
             "request": "launch",

.vscode/settings.json

@@ -1,5 +1,6 @@
 {
-	"git.enableCommitSigning": true,
-	"typescript.tsdk": "node_modules/typescript/lib",
-	"js/ts.implicitProjectConfig.checkJs": true
+    "git.enableCommitSigning": true,
+    "typescript.tsdk": "node_modules/typescript/lib",
+    "js/ts.implicitProjectConfig.checkJs": true,
+    "vitest.rootConfig": "vite.config.ts"
 }

Makefile

@@ -53,6 +53,7 @@ docker-init: ## Start the project in docker
 
 .PHONY: clean
 clean: ## Clean the project
+	@rm -rf node_modules -v
 	@rm -rf */**/node_modules -v
 	@rm -rf dist -v
 

README.md

@@ -2,7 +2,7 @@
 
 # mcos
 
-[![Node.js CI](https://github.com/drazisil/mcos/actions/workflows/node.yml/badge.svg?branch=dev)](https://github.com/drazisil/mcos/actions/workflows/node.yml) [![CodeQL](https://github.com/drazisil/mcos/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/drazisil/mcos/actions/workflows/codeql-analysis.yml?branch=dev) [![codecov](https://codecov.io/gh/rustymotors/server/graph/badge.svg?token=XiwYgbHCeN)](https://codecov.io/gh/rustymotors/server)  [![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)](https://github.com/prettier/prettier)
+[![Node.js CI](https://github.com/drazisil/mcos/actions/workflows/node.yml/badge.svg?branch=dev)](https://github.com/drazisil/mcos/actions/workflows/node.yml) [![CodeQL](https://github.com/drazisil/mcos/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/drazisil/mcos/actions/workflows/codeql-analysis.yml?branch=dev) [![codecov](https://codecov.io/gh/rustymotors/server/graph/badge.svg?token=XiwYgbHCeN)](https://codecov.io/gh/rustymotors/server) [![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)](https://github.com/prettier/prettier) ![CodeRabbit Pull Request Reviews](https://img.shields.io/coderabbit/prs/github/rustymotors/server?utm_source=oss&utm_medium=github&utm_campaign=rustymotors%2Fserver&labelColor=171717&color=FF570A&link=https%3A%2F%2Fcoderabbit.ai&label=CodeRabbit+Reviews)
 
 ## About
 
@@ -18,20 +18,21 @@ There's a brief explanation of the thought process here [link](https://github.co
 
 ## Server Setup
 
--   See [server docs](./docs/server.md)
+- See [server docs](./docs/server.md)
+- See [configuration docs](./config/README.md)
 
 ## Client Setup
 
--   See [client docs](./docs/client.md)
+- See [client docs](./docs/client.md)
 
 ## Timeline
 
--   March 6, 2016 - Started
+- March 6, 2016 - Started
 
--   October 12, 2023 - Connected to lobby
+- October 12, 2023 - Connected to lobby
 
 ![img The first non-hacked image of the MCO lobby since it was shutdown](images/2012-10-12_lobby.png)
 
 ## Current Status
 
--   [TODO Issues](https://github.com/drazisil/mcos/labels/todo%20%3Aspiral_notepad%3A)
+- [TODO Issues](https://github.com/drazisil/mcos/labels/todo%20%3Aspiral_notepad%3A)

config/README.md

@@ -0,0 +1,82 @@
+# Configuration System for Rusty Motors Server
+
+This project uses the [`config`](https://www.npmjs.com/package/config) and [`dotenv`](https://www.npmjs.com/package/dotenv) packages for secure, flexible, and environment-based configuration management.
+
+## How It Works
+
+- **Config Directory:** All configuration files are located in the root-level `config/` directory.
+- **Default Values:** The main configuration is in `config/default.json`.
+- **Environment Variables:** You can override any config value using environment variables, as mapped in `config/custom-environment-variables.json`.
+- **.env Support:** You can also use a `.env` file in the project root to set environment variables for local development.
+- **Environment-Specific Config:** You can add files like `config/production.json` or `config/development.json` for environment-specific overrides.
+
+## How to Use
+
+1. **Edit `config/default.json`** to set project-wide defaults (see example below).
+2. **Override with environment variables** (e.g., in your shell, CI/CD, or `.env` file):
+    - Example: `export CERTIFICATE_FILE=/path/to/cert.pem`
+3. **(Optional) Add a `.env` file** in the project root for local development:
+    ```env
+    CERTIFICATE_FILE=./data/mcouniverse.crt
+    PRIVATE_KEY_FILE=./data/private_key.pem
+    PUBLIC_KEY_FILE=./data/pub.key
+    EXTERNAL_HOST=localhost
+    MCO_LOG_LEVEL=debug
+    ```
+4. **(Optional) Add `production.json`, `test.json`, etc.** for environment-specific config.
+
+## Example: `config/default.json`
+
+```json
+{
+    "host": "localhost",
+    "logLevel": "debug",
+    "certificateFile": "./data/mcouniverse.crt",
+    "privateKeyFile": "./data/private_key.pem",
+    "publicKeyFile": "./data/pub.key"
+}
+```
+
+## Example: `config/custom-environment-variables.json`
+
+```json
+{
+    "host": "EXTERNAL_HOST",
+    "logLevel": "MCO_LOG_LEVEL",
+    "certificateFile": "CERTIFICATE_FILE",
+    "privateKeyFile": "PRIVATE_KEY_FILE",
+    "publicKeyFile": "PUBLIC_KEY_FILE"
+}
+```
+
+## How the Code Loads Config
+
+The code uses the `config` package to load settings. For example:
+
+```typescript
+import config from 'config';
+const host = config.get<string>('host');
+```
+
+Or, using the provided helper:
+
+```typescript
+import { getServerConfiguration } from 'rusty-motors-shared';
+const config = getServerConfiguration();
+console.log(config.host);
+```
+
+## Best Practices
+
+- **Never commit secrets** (like private keys) directly to config files. Use environment variables or a secure secrets manager.
+- **Document any required config values** for new developers.
+- **Check the config/ directory** for all available options and mappings.
+
+## Further Reading
+
+- [node-config documentation](https://github.com/node-config/node-config/wiki/Configuration-Files)
+- [dotenv documentation](https://github.com/motdotla/dotenv)
+
+---
+
+For questions, see the project README or ask in the project chat.

config/custom-environment-variables.json

@@ -0,0 +1,7 @@
+{
+  "host": "EXTERNAL_HOST",
+  "logLevel": "MCO_LOG_LEVEL",
+  "certificateFile": "CERTIFICATE_FILE",
+  "privateKeyFile": "PRIVATE_KEY_FILE",
+  "publicKeyFile": "PUBLIC_KEY_FILE"
+}

config/default.json

@@ -0,0 +1,7 @@
+{
+  "host": "localhost",
+  "logLevel": "debug",
+  "certificateFile": "./data/mcouniverse.crt",
+  "privateKeyFile": "./data/private_key.pem",
+  "publicKeyFile": "./data/pub.key"
+}

instrument.mjs

@@ -2,16 +2,14 @@ import * as Sentry from '@sentry/node';
 import { nodeProfilingIntegration } from '@sentry/profiling-node';
 
 Sentry.init({
-	dsn: process.env['SENTRY_DSN'],
-	integrations: [
-	  // Add our Profiling integration
-	  nodeProfilingIntegration(),
-	],
-
-	// We recommend adjusting this value in production, or using tracesSampler
-	// for finer control
-	tracesSampleRate: 1.0,
-	profilesSampleRate: 1.0, // Profiling sample rate is relative to tracesSampleRate
+    dsn: process.env['SENTRY_DSN'],
+    integrations: [
+        // Add our Profiling integration
+        nodeProfilingIntegration(),
+    ],
+
+    // We recommend adjusting this value in production, or using tracesSampler
+    // for finer control
+    tracesSampleRate: 1.0,
+    profilesSampleRate: 1.0, // Profiling sample rate is relative to tracesSampleRate
 });
-
-

libs/@rustymotors/binary/src/index.ts

@@ -1,5 +1,21 @@
-export * from "./lib/Bytable";
-export * from "./lib/BytableContainer";
-export * from "./lib/BytableDword";
-export * from "./lib/BytableHeader";
-export * from "./lib/BytableMessage";
+// mcos is a game server, written from scratch, for an old game
+// Copyright (C) <2017>  <Drazi Crendraven>
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published
+// by the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+export * from './lib/Bytable.js';
+export * from './lib/BytableContainer.js';
+export * from './lib/BytableDword.js';
+export * from './lib/BytableHeader.js';
+export * from './lib/BytableMessage.js';