Add strict ordering of commitment_signed and tx_signatures#9
Open
ddustin wants to merge 11 commits intorustyrussell:guilt/splicefrom
Open
Add strict ordering of commitment_signed and tx_signatures#9ddustin wants to merge 11 commits intorustyrussell:guilt/splicefrom
commitment_signed and tx_signatures#9ddustin wants to merge 11 commits intorustyrussell:guilt/splicefrom
Conversation
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is especially useful for protocols such as splicing; for simplified commitment transactions, there is already an implied initiator at each point, so having the negotiation at splicing time would be redundant. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… channel. The initiator (in the case of simultaneity, the higher feepayer) pays for the input and output, and sets the feerate. We freeze the channel while this construction is going on: it should be quick. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Header from folded patch 'fixup3.patch': fixup! splicing: use the generic negotiation mechanism to splice in/out of a channel. - Remove 1 per minute restriction: 25% growth limits us a lot (@niftynei) - Nomenclature: initiator, splice transaction, channel funding output. - Weaken reserve check to only cover iff they extract funds.
This is much simpler. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Header from folded patch 'fixup2.patch': fixup! splice_locked: terminate this splice once one reaches agreed depths. Use 6; we need to start announcing then anyway, so keep it simple.
This was Matt Corallo's idea; a simple flag means you should keep using the channel as it's being replaced. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Header from folded patch 'fixup.patch': fixup! gossip: make sure to send new announcement_signatures post-splice. It's called `splice_locked` and it's always sent 6 blocks.
…etting fees. Any changes must be valid for all possible commitment transactions. A minor change, but for implementations which quote the spec and check those quotes this will highlight the changes needed. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is important for preventing fund griefing along long chains of combined splices as well as creating clean `tx_abort` logic. In line w/convo with @niftynei See comment here: https://github.com/lightning/bolts/pull/863/files#r897441047
ddustin
force-pushed
the
guilt/splice
branch
2 times, most recently
from
92d647b to
03c47c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is important for preventing fund griefing along long chains of combined splices as well as creating clean
tx_abortlogic.In line w/convo with @niftynei
See comment here: https://github.com/lightning/bolts/pull/863/files#r897441047