Skip to content

fix(mcp): rvlite tools now use ESM dynamic import for v0.2.x compatibility #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luminexo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mcp): rvlite tools now use ESM dynamic import for v0.2.x compatibility #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 42 additions & 33 deletions npm/packages/ruvector/bin/mcp-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3068,18 +3068,39 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
}

// ── rvlite Query Tool Handlers ──────────────────────────────────────
// Helper for ESM-only rvlite (v0.2.x exports ESM only)
async function getRvliteEngine() {
const rvlite = await import('rvlite/wasm');
// Load WASM binary synchronously for Node.js
const { readFileSync } = await import('fs');
const { createRequire } = await import('module');
const require = createRequire(import.meta.url || __filename);
let wasmPath;
try {
wasmPath = require.resolve('rvlite/dist/wasm/rvlite_bg.wasm');
} catch {
// Fallback: try common locations
const path = await import('path');
const wasmDir = path.join(require.resolve('rvlite'), '..', 'dist', 'wasm', 'rvlite_bg.wasm');
wasmPath = wasmDir;
}
const wasmBuffer = readFileSync(wasmPath);
rvlite.initSync(wasmBuffer);
return rvlite;
}

// Cache the engine to avoid re-initializing on every call
let rvliteEngineCache = null;
async function getRvliteEngineCached() {
if (!rvliteEngineCache) {
rvliteEngineCache = await getRvliteEngine();
}
return rvliteEngineCache;
}

case 'rvlite_sql': {
try {
let rvlite;
try {
rvlite = require('rvlite');
} catch (_e) {
return { content: [{ type: 'text', text: JSON.stringify({
success: false,
error: 'rvlite package not installed',
hint: 'Install with: npm install rvlite'
}, null, 2) }] };
}
const rvlite = await getRvliteEngineCached();
const safeQuery = sanitizeShellArg(args.query);
const dbOpts = args.db_path ? { path: validateRvfPath(args.db_path) } : {};
const db = new rvlite.Database(dbOpts);
Expand All @@ -3091,25 +3112,18 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
row_count: Array.isArray(results) ? results.length : 0
}, null, 2) }] };
} catch (e) {
const isEsmError = e.message && (e.message.includes('ESM') || e.message.includes('import') || e.message.includes('require'));
return { content: [{ type: 'text', text: JSON.stringify({
success: false,
error: e.message
error: e.message,
hint: isEsmError ? 'rvlite v0.2.x is ESM-only. Use Node.js with --experimental-vm-modules or ES module context.' : 'Install with: npm install rvlite'
}, null, 2) }], isError: true };
}
}

case 'rvlite_cypher': {
try {
let rvlite;
try {
rvlite = require('rvlite');
} catch (_e) {
return { content: [{ type: 'text', text: JSON.stringify({
success: false,
error: 'rvlite package not installed',
hint: 'Install with: npm install rvlite'
}, null, 2) }] };
}
const rvlite = await getRvliteEngineCached();
const safeQuery = sanitizeShellArg(args.query);
const dbOpts = args.db_path ? { path: validateRvfPath(args.db_path) } : {};
const db = new rvlite.Database(dbOpts);
Expand All @@ -3121,25 +3135,18 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
row_count: Array.isArray(results) ? results.length : 0
}, null, 2) }] };
} catch (e) {
const isEsmError = e.message && (e.message.includes('ESM') || e.message.includes('import') || e.message.includes('require'));
return { content: [{ type: 'text', text: JSON.stringify({
success: false,
error: e.message
error: e.message,
hint: isEsmError ? 'rvlite v0.2.x is ESM-only. Use Node.js with --experimental-vm-modules or ES module context.' : 'Install with: npm install rvlite'
}, null, 2) }], isError: true };
}
}

case 'rvlite_sparql': {
try {
let rvlite;
try {
rvlite = require('rvlite');
} catch (_e) {
return { content: [{ type: 'text', text: JSON.stringify({
success: false,
error: 'rvlite package not installed',
hint: 'Install with: npm install rvlite'
}, null, 2) }] };
}
const rvlite = await getRvliteEngineCached();
const safeQuery = sanitizeShellArg(args.query);
const dbOpts = args.db_path ? { path: validateRvfPath(args.db_path) } : {};
const db = new rvlite.Database(dbOpts);
Expand All @@ -3151,9 +3158,11 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
row_count: Array.isArray(results) ? results.length : 0
}, null, 2) }] };
} catch (e) {
const isEsmError = e.message && (e.message.includes('ESM') || e.message.includes('import') || e.message.includes('require'));
return { content: [{ type: 'text', text: JSON.stringify({
success: false,
error: e.message
error: e.message,
hint: isEsmError ? 'rvlite v0.2.x is ESM-only. Use Node.js with --experimental-vm-modules or ES module context.' : 'Install with: npm install rvlite'
}, null, 2) }], isError: true };
}
}
Expand Down