Add VisionFive 2 Lite test cases and docs#4
Open
zhiyao310 wants to merge 13 commits intoruyisdk:mainfrom
Open
Conversation
Reviewer's GuideAdds VisionFive 2 Lite board docs plus Chinese-language getting-started guides for HelloWorld and CoreMark benchmarks, including step-by-step usage with GNU and LLVM Ruyi toolchains on Ubuntu 24.04. Flow diagram for VisionFive2Lite Coremark GCC and LLVM workflowsflowchart TD
A_Start["Start on Ubuntu 24.04"] --> B_InstallRuyi["Install ruyi package manager"]
B_InstallRuyi --> C_InstallToolchains["ruyi install gnu-plct and llvm-plct"]
C_InstallToolchains --> D_CoremarkRepo["Clone coremark repository"]
subgraph GCC_workflow
D_CoremarkRepo --> E_GCCVenv["ruyi venv -t toolchain/gnu-plct manual venv-gnu-plct"]
E_GCCVenv --> F_ActivateGCC["Activate venv-gnu-plct"]
F_ActivateGCC --> G_VerifyGCC["riscv64-plct-linux-gnu-gcc -v"]
G_VerifyGCC --> H_BuildCoremarkGCC["make CC=riscv64-plct-linux-gnu-gcc XCFLAGS='-march=rv64gc_zba_zbb' compile"]
H_BuildCoremarkGCC --> I_RunCoremarkGCC["Run ./coremark.exe"]
I_RunCoremarkGCC --> J_CheckOutputGCC["Check Correct operation validated and performance scores"]
J_CheckOutputGCC --> K_DeactivateGCC["ruyi-deactivate"]
end
subgraph LLVM_workflow
C_InstallToolchains --> L_LLVMVenv["ruyi venv -t toolchain/llvm-plct manual --sysroot-from gnu-plct venv-llvm-plct"]
L_LLVMVenv --> M_ActivateLLVM["Activate venv-llvm-plct"]
M_ActivateLLVM --> N_VerifyClang["clang -v"]
N_VerifyClang --> O_CleanCoremark["make clean in coremark"]
O_CleanCoremark --> P_BuildCoremarkLLVM["make CC=clang XCFLAGS='-march=rv64gc_zba_zbb' compile"]
P_BuildCoremarkLLVM --> Q_RunCoremarkLLVM["Run ./coremark.exe"]
Q_RunCoremarkLLVM --> R_CheckOutputLLVM["Check Correct operation validated and performance scores"]
R_CheckOutputLLVM --> S_DeactivateLLVM["ruyi-deactivate"]
end
K_DeactivateGCC --> T_End["Coremark GCC workflow complete"]
S_DeactivateLLVM --> U_EndLLVM["Coremark LLVM workflow complete"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 5 issues, and left some high level feedback:
- In both HelloWorld and Coremark Chinese READMEs, the section titles after the LLVM examples still say “退出ruyi GCC虚拟环境”; consider updating these to refer to the LLVM virtual environment for clarity.
- There is a mix of “VisionFive2 Lite” and “VisionFive 2 Lite” in the new docs; aligning on a single naming style (with or without the space) will avoid confusion and make search/indexing more consistent.
- The repeated setup steps for installing Ruyi and toolchains in the HelloWorld and Coremark READMEs could be factored out or referenced from a shared section to reduce duplication and keep future updates simpler.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In both HelloWorld and Coremark Chinese READMEs, the section titles after the LLVM examples still say “退出ruyi GCC虚拟环境”; consider updating these to refer to the LLVM virtual environment for clarity.
- There is a mix of “VisionFive2 Lite” and “VisionFive 2 Lite” in the new docs; aligning on a single naming style (with or without the space) will avoid confusion and make search/indexing more consistent.
- The repeated setup steps for installing Ruyi and toolchains in the HelloWorld and Coremark READMEs could be factored out or referenced from a shared section to reduce duplication and keep future updates simpler.
## Individual Comments
### Comment 1
<location path="VisionFive2Lite/Coremark/README_zh.md" line_range="85" />
<code_context>
+```
+
+
+退出ruyi GCC虚拟环境
+
+```
</code_context>
<issue_to_address>
**issue (typo):** LLVM section exit description refers to "GCC" instead of "LLVM".
Since this is in the LLVM section, please update the heading text to “退出ruyi LLVM虚拟环境” to avoid confusion.
```suggestion
退出ruyi LLVM虚拟环境
```
</issue_to_address>
### Comment 2
<location path="VisionFive2Lite/Coremark/README_zh.md" line_range="88" />
<code_context>
+退出ruyi GCC虚拟环境
+
+```
+cd ..; ruyi-deactivate
+```
+
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Non-breaking space before ".." may cause copy-paste issues.
The space between `cd` and `..` is a non‑breaking space, which can break copy/paste usage. Please replace it with a normal space (e.g. `cd ..; ruyi-deactivate`) here and in the HelloWorld README.
Suggested implementation:
```
退出ruyi GCC虚拟环境
```
cd ..; ruyi-deactivate
```
sys: ubuntu
```
同样的修改需要在 HelloWorld 的 README 中进行:检查对应的“退出 ruyi GCC 虚拟环境”步骤,将其中的 `cd` 与 `..` 之间的非断行空格替换为普通空格,确保示例命令为 `cd ..; ruyi-deactivate`,以避免用户复制粘贴时出现问题。
</issue_to_address>
### Comment 3
<location path="VisionFive2Lite/HelloWorld/README_zh.md" line_range="77" />
<code_context>
+```
+
+
+退出ruyi GCC虚拟环境
+
+```
</code_context>
<issue_to_address>
**issue (typo):** LLVM section exit description refers to "GCC" instead of "LLVM".
Since this heading is in the LLVM section, please change "退出ruyi GCC虚拟环境" to "退出ruyi LLVM虚拟环境" for consistency.
```suggestion
退出ruyi LLVM虚拟环境
```
</issue_to_address>
### Comment 4
<location path="VisionFive2Lite/README.md" line_range="10" />
<code_context>
+silicon_vendor: StarFive
+---
+
+# VisionFive2 Lite
+
+VisionFive 2 Lite is an entry-level RISC-V single-board computer with a low barrier to entry and rich functionality, suitable for education, AIoT, smart home, and industrial IoT scenarios. Powered by the StarFive JH-7110S quad-core processor, the board delivers strong image and video processing capabilities, and features extensive expansion interfaces including PCIe, HDMI, USB 3.0, and Gigabit Ethernet. It is fully compatible with mainstream Linux distributions and open-source toolchains, helping developers achieve rapid development and seamless integration. Whether for learning and research, prototype development, or embedded deployment, VisionFive 2 Lite strikes an excellent balance between performance and cost.
</code_context>
<issue_to_address>
**nitpick (typo):** Product name heading lacks a space compared to the metadata.
The front-matter uses "VisionFive 2 Lite" (with a space), while the heading uses "VisionFive2 Lite". Please align the heading with the metadata for consistency.
```suggestion
# VisionFive 2 Lite
```
</issue_to_address>
### Comment 5
<location path="VisionFive2Lite/README_zh.md" line_range="10" />
<code_context>
+silicon_vendor: StarFive
+---
+
+# VisionFive2 Lite
+
+VisionFive 2 Lite is an entry-level RISC-V single-board computer with a low barrier to entry and rich functionality, suitable for education, AIoT, smart home, and industrial IoT scenarios. Powered by the StarFive JH-7110S quad-core processor, the board delivers strong image and video processing capabilities, and features extensive expansion interfaces including PCIe, HDMI, USB 3.0, and Gigabit Ethernet. It is fully compatible with mainstream Linux distributions and open-source toolchains, helping developers achieve rapid development and seamless integration. Whether for learning and research, prototype development, or embedded deployment, VisionFive 2 Lite strikes an excellent balance between performance and cost.
</code_context>
<issue_to_address>
**nitpick (typo):** Chinese README heading uses "VisionFive2 Lite" instead of "VisionFive 2 Lite".
The front matter uses "VisionFive 2 Lite" (with a space), while the heading is "VisionFive2 Lite". Please update the heading to match the "VisionFive 2 Lite" naming for consistency.
```suggestion
# VisionFive 2 Lite
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
DuoQilai
requested changes
Apr 28, 2026
Co-authored-by: DuoQilai <101803232+DuoQilai@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Information
Board Model: VisionFive 2 Lite
Ruyi Version: 0.47.0
Toolchains:
GNU Toolchain: gnu-plct
LLVM Toolchain: llvm-plct
Added Content
Added HelloWorld test cases (GCC/Clang versions)
Added CoreMark performance test cases (GCC/Clang versions, with valid run time ≥ 10s)
Added board documentation:
README\.mdREADME\_zh\.mdTest Results
All tests passed successfully:
HelloWorld builds and runs correctly with valid output
CoreMark runs stably and outputs valid performance scores with
Correct operation validatedNo illegal instruction, build failure or crash issues
Summary by Sourcery
Add VisionFive 2 Lite board documentation and basic RuyiSDK usage guides for Hello World and CoreMark.
Documentation: