Send null timezone at login so account zone isn't overwritten (#29) - #32
Merged
Conversation
The login request's timezone field is a write, not a hint: sending a non-null zone overwrites the account's server-side timezone on every login (verified against the live API). Older builds hardcoded "America/New_York", silently resetting every user's account zone to Eastern and poisoning the account-timezone stamping added in #27. Send null instead, which leaves the account setting intact and lets the response report the real zone. Add a CRONOMETER_ACCOUNT_TZ override that takes precedence over both the response and a cached session, as an escape hatch for accounts whose zone was already clobbered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login request's timezone field is a write, not a hint: sending a non-null zone overwrites the account's server-side timezone on every login (verified against the live API). Older builds hardcoded "America/New_York", silently resetting every user's account zone to Eastern and poisoning the account-timezone stamping added in #27.
Send null instead, which leaves the account setting intact and lets the response report the real zone. Add a CRONOMETER_ACCOUNT_TZ override that takes precedence over both the response and a cached session, as an escape hatch for accounts whose zone was already clobbered.