Scale Recipe-food diary nutrients per serving, not per-100g - #34
Merged
Conversation
get_food_log's per-entry enrichment assumed every food stores nutrients per-100g and scaled by grams/100. Custom Recipe foods store nutrients per reference serving, and the diary "grams" field is a serving count, so their per-entry nutrients came out 100x too small (e.g. a taco entry showed 7.79 kcal instead of 779.4). Day-level totals were unaffected. Branch the scale factor on the resolved measure type: use grams directly for Recipe measures, keep grams/100 for Weight/Atomic. Verified against the live diary — the per-entry energy sum now matches Cronometer's server day total.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_food_log's per-entry enrichment assumed every food stores nutrients per-100g and scaled by grams/100. Custom Recipe foods store nutrients per reference serving, and the diary "grams" field is a serving count, so their per-entry nutrients came out 100x too small (e.g. a taco entry showed 7.79 kcal instead of 779.4). Day-level totals were unaffected.
Branch the scale factor on the resolved measure type: use grams directly for Recipe measures, keep grams/100 for Weight/Atomic. Verified against the live diary — the per-entry energy sum now matches Cronometer's server day total.