fix: prevent false success detection when Claude interrupted before real work#19
Merged
Merged
Conversation
…eal work Add timestamp-based commit verification to detect only commits made during current iteration. Previously, Ralph would detect old merge commits and report success even when Claude was interrupted immediately without completing any work. Changes: - Add ITERATION_START_TIME variable captured before execute_agent() - Get commit timestamp using git log --format=%ct - Only report success if commit timestamp > iteration start time - Add warning for commits from previous work - Apply fix to both run_single_iteration() and run_continuous_loop() - Create comprehensive test suite (12 tests) following TDD workflow Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timestamp-based commit verification to detect only commits made during current iteration. Previously, Ralph would detect old merge commits and report success even when Claude was interrupted immediately without completing any work.
Changes: