feat: add optional QA agent second invocation after developer commit#23
Merged
Conversation
Implements Feature 031: after the developer agent commits and quality gates pass, Ralph conditionally invokes a second QA agent that evaluates the feature from a user perspective without reading source files. - ENABLE_QA_AGENT config flag (default: true) controls the second pass - QA agent reads only PRD feature spec and qa-knowledge.md (no source) - QA agent writes a manual E2E test script before any evaluation - On pass: appends structured entry to .ralph/qa-knowledge.md - On fail: creates symptom-only bug ticket in prd.json for next iteration - ENABLE_QA_AGENT=false skips QA entirely, preserving baseline behavior - QA_AGENT_PROMPT.md provides the agent contract and instructions - 32 new tests in tests/ralph-qa-agent-loop.bats (all passing) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Feature 031: after the developer agent commits and quality gates pass, Ralph conditionally invokes a second QA agent that evaluates the feature from a user perspective without reading source files.