Changelog: say which platforms the 11.8.0 lift log actually shipped on - #2328
Merged
Merged
Conversation
…pped on An Android user went looking for the gym log book the release notes announced and could not find it. They were right that there is no entry point: #2099 added the Lift Log to Strand only. Android got #2098's schema and Room twin and #2232's LiftMetrics twin, which is the storage and the maths, and no UI at all. The entry said: An on-device gym log book: build a session, then move between sets with a double-tap on the strap instead of reaching for the phone. Stored in a new schema with a matching Room twin, and the set metrics are computed by the same engine on both platforms. Every clause is true, which is what made it misleading rather than wrong. Both platform phrases in it, "a matching Room twin" and "on both platforms", attach to the two halves Android DID get, so on Android the whole thing reads as an announcement of a feature you have. The same text ships in the in-app changelog on both platforms and in the release doc. Corrected in all four places it appears: the two AppChangelog copies, and the item plus the prose section in docs/releases/v11.8.0.md. It now names iPhone and Mac for the log book, says plainly that Android has the groundwork and not the book, and points at #2327, which tracks the Android UI. Platform-scoping an entry is already the house convention: "iPhone only", "Android only" and "(iPhone and Mac)" all appear in existing entries. The release HEADLINE is deliberately unchanged. Its localized key is derived from its own English text (sha1("A gym log book on your wrist, ...")[:8] = e0f00272), so rewording it would re-key the string and orphan the translation in all eight Android locales plus the xcstrings side, for a headline that is not itself false: the release did ship a gym log book, on two of the three platforms. Changelog item strings are not localized (only the release title is), so this needs no translation work. No behavioural change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Android user on 11.8.0 went looking for the gym log book the release notes announced and could not find an entry point. They were right: there isn't one.
#2099 added the Lift Log to
Strand/only, eight screens. Android got #2098's schema and Room twin and #2232'sLiftMetricstwin, which is the storage and the maths, and no UI at all. #2327 tracks the Android port.What the entry said
Every clause is true, which is what made it misleading rather than wrong. The only two platform phrases in it, "a matching Room twin" and "on both platforms", attach to the two halves Android did get. Nothing says the log book is Apple-only, so on Android it reads as an announcement of a feature you have.
What this changes
All four places the claim appears: the two
AppChangelogcopies and both the item and the prose section indocs/releases/v11.8.0.md. It now names iPhone and Mac for the log book, says plainly that Android has the groundwork rather than the book, and points at #2327.Platform-scoping an entry is already the house convention. "iPhone only", "Android only" and "(iPhone and Mac)" all appear in existing entries; the 11.8.0 item just omitted it.
The headline is deliberately unchanged
docs/releases/v11.8.0.md:3still reads "A gym log book on your wrist, ...". Its localized key is derived from its own English text:Rewording it would re-key the string and orphan every one of those translations plus the xcstrings side, for a headline that is not itself false: the release did ship a gym log book, on two of the three platforms.
Verification
Changelog ITEM strings are not localized, only the release title is, so this needs no translation work.
compileFullDebugKotlincleandoc_comment_lint.pycleani18n_audit.py --ci origin/main --platform androidcleanNo behavioural change; this is release-note text only.