Conversation
…ings and Test Centre All three Save buttons produce identically-named noop-strap-log files, but only this one omitted DebugDataDiagnostics.dynamicLines, so a Live-screen export was silently missing the Strap & data block and the analytics funnels — which button someone pressed changed what a triager received.
Tricked-dev
added a commit
to Tricked-dev/noop
that referenced
this pull request
Sep 21, 2026
Apply the Apple patch from ryanbr/noop PR ryanbr#2367 by @ayiskakov (5cb8e63).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
NOOP has three "Save…" buttons for the strap log — Settings, Test Centre, and the Live screen — all
producing identically-named
noop-strap-log-*.txtfiles. Settings and Test Centre fetchDebugDataDiagnostics.dynamicLines(repo:)and pass it asextraHeaderLines; the Live screen'ssaveStrapLog()did not, so a Live-screen export was silently missing the entire "Strap & data"block and the analytics funnels. Which button someone pressed changed what a triager received, with
nothing in the file saying so.
Field case: two exports from the same install on the same morning — one via Settings (full
diagnostics block), one via the Live screen (session lines only) — which cost a round-trip when the
funnel section was needed.
Change
LiveLogCard.saveStrapLog()now fetches the same extras inside aTask, exactly as the other twocall sites do (
SettingsView.swift,TestCentreView.swift), withAppModeltaken from the SwiftUIenvironment. Copy button behaviour is unchanged on all three surfaces (extras are fetched only for
the file export, matching the existing Settings/Test Centre split).
Platforms
Apple-only by construction: the Android export path already includes the diagnostics block
(
AndroidDiagnostics), so there is no Kotlin twin to change.Verification
Built the
Strand(macOS) scheme locally withxcodebuild … CODE_SIGNING_ALLOWED=NO build—succeeds. (
NOOPiOSleg not buildable on my machine — watchOS 26.2 SDK absent; the change uses thesame pattern that already compiles for iOS at the Settings and Test Centre call sites.) No UI
changes — plumbing only, no tokens involved.