Fixed proxy being ignored#46
Open
abserari wants to merge 1 commit into
Open
Conversation
|
|
||
| // Init setup the apiKey | ||
| func Init(config Config) *TMDb { | ||
| internalConfig := new(tmdbConfig) |
Owner
There was a problem hiding this comment.
Did you mean to remove this line? It looks like only the other change is actually needed.
Author
There was a problem hiding this comment.
But this internalConfig useless，Even if you don't delete it, it won't have any impact.Of course, the best way is for each client to initialize and maintain the proxy information by itself, but it is OK if the library provides a default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.