feat(net): TCP socket implementation with comprehensive test suite #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add complete TCP socket support including: - TCP state machine (SYN, SYN-ACK, ACK, FIN handshakes) - Socket syscalls: socket(SOCK_STREAM), bind, listen, accept, connect, shutdown - Data transfer via read/write on TcpConnection file descriptors - Connection tracking with ConnectionId and TCP_CONNECTIONS table - Port conflict detection (EADDRINUSE) for bind - Blocking connect() that waits for TCP handshake completion New files: - kernel/src/net/tcp.rs: Full TCP implementation - userspace/tests/tcp_socket_test.rs: 11-test validation suite - userspace/tests/tcp_client_test.rs: Interactive TCP client (tcpclient command) - run.sh: Convenience script for interactive mode The tcp_client_test demonstrates end-to-end TCP by connecting to an external host (10.0.2.2:18888 via QEMU SLIRP) and sending "Hello from Breenix!". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The TCP loopback tests were failing because: 1. send_ipv4 only detected loopback for our own IP, not 127.x.x.x 2. handle_ipv4 dropped packets destined for 127.x.x.x 3. tcp_connect stored connections with remote_ip=127.0.0.1, but SYN-ACK replies came from our actual IP, causing lookup mismatch 4. sys_connect didn't drain loopback queue for local packets Fixes: - Accept 127.x.x.x as loopback in send_ipv4 and handle_ipv4 - Normalize loopback addresses to our IP in tcp_connect - Drain loopback queue in connect wait loop All 150 boot stages now pass including TCP tests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…dation Expand TCP test coverage from basic syscall tests to 22 comprehensive tests covering data transfer, shutdown semantics, backlog enforcement, and error handling with strict POSIX compliance. Key changes: - Add EPIPE errno and return it for writes after shutdown - Add tests for bidirectional data, large transfers (256B, MSS boundary) - Add backlog enforcement test that fails if limit not respected - Add ECONNREFUSED/ETIMEDOUT test with specific error code checks - Add client address verification in accept() with 0.0.0.0 failure check - All tests require exact POSIX error codes, not generic failures Validation: Technical Accuracy A-, Intellectual Honesty A, APPROVED Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Implementation:
Test Coverage:
Validation Results:
Test plan
🤖 Generated with Claude Code