Fix potential panic on invalid xml #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for XML formatting functionality and fixes a potential panic when processing malformed XML with excess closing tags. The fix prevents a slice out-of-bounds panic by checking if the stack is empty before attempting to pop elements.
Changes:
- Added guard clause to handle malformed XML with more closing tags than opening tags
- Implemented performance optimization with fast-path check in
escapeXMLString - Added comprehensive test suite covering valid XML, malformed XML, output verification, and XML string escaping
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/format/xml.go | Added stack length validation before popping elements to prevent panic; added fast-path optimization for XML string escaping |
| internal/format/xml_test.go | Added comprehensive test coverage for XML formatting, malformed XML handling, and string escaping |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.