Skip to content

Added a setup.py and made path to tables and models configurable#32

Open
jaderabbit wants to merge 8 commits into
ryankiros:masterfrom
RetroRabbit:feature/setup
Open

Added a setup.py and made path to tables and models configurable#32
jaderabbit wants to merge 8 commits into
ryankiros:masterfrom
RetroRabbit:feature/setup

Conversation

@jaderabbit

@jaderabbit jaderabbit commented Oct 12, 2016

Copy link
Copy Markdown
  • Added setup.py so that can be installed by pip
  • Made the path to tables and models configurable from load_model, with sensible defaults
  • Adjusted readme
  • Added init.py

Comment thread skipthoughts.py
"""
Load the model with saved tables
"""
path_to_umodel = path_to_models + 'uni_skip.npz'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please replace the '+' operator with os.path.join()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants