fix(srv6): free the tenant VRF on discard, not only on successful teardown#20
Merged
Merged
Conversation
…rdown reconcileLocked always allocs a VRF table id before InstallGateway, but teardownLocked (the only caller of vrfs.free) early-returned when st.install == nil. A policy whose install failed (st.install stays nil) and is then deleted or pruned therefore never freed its VRF: byUID grew unbounded and table ids climbed monotonically. Restructure teardownLocked to gate only WithdrawSID/RemoveGateway on st.install != nil and free the VRF unconditionally, restoring alloc/free symmetry. Adds TestGateway_FailedInstallFreesVRF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
reconcileLockedalways allocs a VRF table id beforeInstallGateway, butteardownLocked(the only caller ofvrfs.free) early-returned whenst.install == nil. So a policy whose install failed (st.install stays nil) and is later deleted/pruned never freed its VRF —byUIDgrew unbounded, table ids climbed forever.Fix
Gate only
WithdrawSID/RemoveGatewayonst.install != nil; free the VRF unconditionally. AddsTestGateway_FailedInstallFreesVRF.Review finding
Medium #9.
Test
go test ./calico-vpp-agent/srv6egress/...green;GOOS=linux go vetgreen.