fix(srv6): stop leaking a goroutine per EgressPolicy Watch() retry#27
Merged
Merged
Conversation
The 'go func(){ <-t.Dying(); cancel() }()' helper blocked on t.Dying()
whenever Watch returned for a non-shutdown reason (List/Watch error,
result channel closed). The caller re-invokes Watch() in a loop, so an
API-server outage leaked one goroutine per retry (~720/hour). Select on
ctx.Done() as well so the deferred cancel() unblocks it on every return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
go func(){ <-t.Dying(); cancel() }()helper blocked ont.Dying()wheneverWatchreturned for a non-shutdown reason (List/Watch error, result channel closed). The caller re-invokesWatch()in a loop, so an API-server outage leaked one goroutine per retry (~720/hour).Fix
selectonctx.Done()as well, so the deferredcancel()unblocks the helper on every return.Review finding
Low (concurrency) C1.
Test
go test ./calico-vpp-agent/srv6egress/...+GOOS=linux go vetgreen.