fix(srv6): reject colliding terminal SIDs under color-route encoding#30
Merged
Merged
Conversation
Under --bgp-encoding=color-route the NLRI is the terminal SID /128 and the color is only a Color Extended Community attribute, so two colors whose segment list ends at the same SID collapse onto one BGP path: the second Announce replaces the first, and withdrawing either withdraws the shared route. Reject such a config at load (the default sr-policy encoding carries the color in the NLRI key and is unaffected).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Under
--bgp-encoding=color-routethe NLRI is the terminal SID/128and the color is only a Color Extended Community attribute, so two colors whose segment list ends at the same SID collapse onto one BGP path — the second Announce replaces the first, and withdrawing either withdraws the shared route.Fix
Reject such a config at load, in the color-route branch (mirrors the sr-policy bsid check). The default sr-policy encoding carries the color in the NLRI key and is unaffected.
Review finding
Low (correctness) L7.
Test
go build/vet ./srv6egress/cmd/...green.