fix(srv6): materialize the OnUnavailable=Drop default in the CRD#32
Merged
Merged
Conversation
The documented default 'Drop' lived only in agent code (onUnavailableDrop treats empty as Drop), so a stored EgressPolicy kept onUnavailable="" and any other reader saw no default. Add +kubebuilder:default=Drop and the matching 'default: Drop' in the generated CRD so the API server defaults the field server-side, removing the split-brain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The documented default
Droplived only in agent code (onUnavailableDroptreats empty as Drop), so a stored EgressPolicy keptonUnavailable=""and any other reader saw no default — split-brain.Fix
Add
+kubebuilder:default=Dropon the field and the matchingdefault: Dropin the generated CRD, so the API server defaults it server-side.Review finding
Low (tests/API) T2.
Test
go test ./srv6egress/...green; CRD yaml still parses.