Japanese Localization Improvements for HextechRunes 0.9.3 - #32
Open
RainBreath7th wants to merge 3 commits into
Open
RainBreath7th wants to merge 3 commits into
RainBreath7th wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I made some revisions to the Japanese localization
Change
Corrected a large number of unnatural Japanese sentences, grammatical issues, and mistranslations. English text that had not yet been translated into Japanese was also translated where appropriate.
Some runes names use the official Japanese translations used in League of Legends.
Slay the Spire 2 terminology has been retained according to the game's official Japanese translations.
Reordered some JSON keys so that they follow the same order as the Chinese localization files. This makes the two files easier to compare and cross-reference during translation review.
No compilation validation has been performed. I only change the Japanese localization files.