Cleanup code, add proper error handling#97
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on cleanup and more robust error handling across the flow runtime and executor code paths.
Changes:
- Simplifies redundant error construction and adds Redis command error checks in the runtime.
- Fixes JSON struct tags for executor requests (ensuring proper marshal/unmarshal behavior).
- Prevents potential nil dereferences during executor cleanup and adds error handling around data store copying.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
runtime/flow_runtime.go |
Removes redundant fmt.Sprintf usage and adds error handling for Redis Set/Del. |
core/sdk/executor/request.go |
Fixes invalid JSON tags and a minor comment formatting issue. |
core/sdk/executor/executor.go |
Adds nil-guards for dataStore.Cleanup(), improves failure logging, and handles CopyStore() errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: s8sg <7374058+s8sg@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
Applied in this branch via commits 5146465 and 612ab13. The executor failure path now preserves and reports the original error, and the local |
|
@copilot Fix the test cases that are failing |
I checked the failing run and re-ran tests on this branch: |
This PR focuses on cleanup and more robust error handling across the flow runtime and executor code paths.
Changes:
Simplifies redundant error construction and adds Redis command error checks in the runtime.
Fixes JSON struct tags for executor requests (ensuring proper marshal/unmarshal behavior).
Prevents potential nil dereferences during executor cleanup and adds error handling around data store copying.