(docs): color picker improve color text representation and make dialog transparent on android #4322
+37
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pdanpdan
commented
Nov 29, 2025
pdanpdan
commented
- fix ring on selected color in palette on mobiles
- do not add decimals for oklch and hsl if the value is an integer after truncation
- always update hue in oklch (even if chroma is 0)
- when the color is updated from sliders the hue is not changed when changing chroma
- when a color is picked from palette the hue slider should reflect selection
- when text value of the color is changed the hue slider should reflect selection
- make dialog also hide on android when range input is dragged
- on android the range input loses :active when dragged
- it needs attaching events for touch and mouse because pointercancel is called on move (even if setPointerCapture is used - probably because svelte re-renders/modifies the control)
- when the color is updated from sliders the hue is not changed when changing chroma - when a color is picked from palette the hue slider should reflect selection - when text value of the color is changed the hue slider should reflect selection
- on android the range input loses :active when dragged - it needs attaching events for touch and mouse because pointercancel is called on move (even if setPointerCapture is used - probably because svelte re-renders/modifies the control)
Owner
|
Thank you @pdanpdan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.