docs(docs): mark ADR 0012 complete with full PR timeline#95
Merged
Conversation
ADR 0012 was written after the pilot (PR #77) when only security_commands.rs had migrated, so its status said "Accepted (pilot); full rollout deferred" and its migration-runway table listed 13 remaining files. Every one of those files migrated in the same session. This update captures the completion state: - Status changed to "Accepted — full migration complete". - New "Migration timeline" section with a PR-by-PR table (#77 pilot through #94 final), including notable per-domain decisions like the From<JiraError> enum-backed impl and the "Image too large" test preservation. - New "Dead-code sweeps" note capturing the ~2,026 LOC of duplicate Tauri wrappers deleted from commands/mod.rs across PRs #82, #83, #85, #89. - "Final-state counts" section with reproducible grep commands; verified Result<T, String> count in src-tauri/src/commands/ is now zero. - "Residual pointers" section flags generate_kb_embeddings_internal (a pub(super) helper still on String, not Tauri-exposed), the cosmetic inconsistency of kb_commands.rs's Tauri wrappers still declaring Result<_, String> while their _impls return AppError, and a suggested frontend helper for typed [CODE] branching. - Context section updated to include From<JiraError> alongside the other From impls listed there. No code changes. Docs-only PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR 0012 was written mid-session after only
security_commands.rshad migrated, so its status said "Accepted (pilot); full rollout deferred" and its runway table listed 13 remaining files. Every file in that table migrated in the same session. This doc-only PR captures completion.Changes
Accepted — full migration complete.From<JiraError>enum-backed impl in refactor(src): migrate jira commands to AppError with From<JiraError> #81, preserving the "Image too large" wording in refactor(src): migrate runtime helpers + OCR + downloads to AppError #92 so a contract test stays valid, and the careful handling ofrecovery_result_from_database_error(error: String)in refactor(src): migrate startup commands to AppError (last file!) #94 to keep rusqlite-phrase pattern matching intact.commands/mod.rs.mod.rs: 6,022 → ~3,950 lines.grepcommands, confirmingResult<T, String>count insrc-tauri/src/commands/is zero.pub(super)generate_kb_embeddings_internal, cosmetic inconsistency of kb_commands' wrapper layer, and a suggested frontend helper for typed[CODE]branching).From<JiraError>alongside the pre-existing From impls.Scope
Docs-only. No Rust changes, no test changes.
Test plan
🤖 Generated with Claude Code