fix(release): skip the Vercel preview toolbar in live parity checks - #27
Merged
Conversation
Preview deployments append the Vercel Toolbar script after </html> on the root document only, so the one-shell comparison across the eight routes failed once the protection bypass let the check read a preview. Send x-vercel-skip-toolbar so the root hashes like every rewritten route.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the preview toolbar in live parity checks
With the protection bypass in place, the preview check reached the content and failed on the next assertion: preview deployments append the Vercel Toolbar script after
</html>on the root document only, so/hashed differently from the seven rewritten routes.scripts/check-live-parity.ts: sendx-vercel-skip-toolbar: 1on every fetch. Vercel then serves the root document without the injection.scripts/check-live-parity.test.ts: the header is present on every request.RELEASE.md: one sentence under step 8.Verified: typecheck, 209 unit tests, guard scan clean. RELEASE.md step 8 now passes end to end against a protected preview with the project's automation bypass secret, and step 9 still passes against both production aliases.