chore: set failOnDeprecation in phpunit - #788
Merged
Merged
Conversation
Signed-off-by: Phillip Davis <phil@jankaritech.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
=========================================
Coverage 98.66% 98.66%
Complexity 1748 1748
=========================================
Files 71 71
Lines 5154 5154
=========================================
Hits 5085 5085
Misses 69 69 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This avoids deprecation warnings from phpunit in PHP 8.5 about the code using the null value of group as an array key. Note that in PHP 8, trying to use null as an array key results in the empty string being used as the array key. So this was the underlying behavior anyway, but better to now explicitly use the empty string. Signed-off-by: Phillip Davis <phil@jankaritech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.