Do not escape commas in Uri values - #789
Open
KristofferFM wants to merge 5 commits into
Open
KristofferFM wants to merge 5 commits into
KristofferFM wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #789 +/- ##
============================================
- Coverage 98.66% 98.66% -0.01%
Complexity 1748 1748
============================================
Files 71 71
Lines 5154 5153 -1
============================================
- Hits 5085 5084 -1
Misses 69 69 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KristofferFM
changed the title
KristofferFM
marked this pull request as draft
September 9, 2026 14:31
KristofferFM
marked this pull request as ready for review
September 9, 2026 15:25
KristofferFM
changed the title
Contributor
Author
|
I will look into the failing checks asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uri values, as found in PHOTO and GEO properties, should not have comma escaped. An example of a valid PHOTO property can be seen here: https://datatracker.ietf.org/doc/html/rfc6350#section-6.2.4.
As a result of this change, I had to modify an existing testcase that uses a Uri value with geo: scheme.