Skip to content

fix: handle UTC offset timezones - #790

Open
SebastianKrupinski wants to merge 1 commit into
sabre-io:masterfrom
SebastianKrupinski:fix/handle-utc-offset-timezones
Open

SebastianKrupinski wants to merge 1 commit into
sabre-io:masterfrom
SebastianKrupinski:fix/handle-utc-offset-timezones

Conversation

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Summary

  • added logic to handle UTC offset timezones properly "DTSTART;TZID="UTC-04:00":20260728T111500"

@pi0n00r

pi0n00r commented Sep 14, 2026

Copy link
Copy Markdown

Thanks for moving this into the shared timezone parser. This covers the original UTC-04:00 case (and the compact UTC-0400 form) at the correct layer, so it is preferable to retaining a Calendar Dashboard-only correction.

The current CI failures appear limited to the two new PHPUnit data providers: PHPUnit 11 requires them to be static, and Rector expects #[DataProvider(...)] attributes rather than @dataProvider annotations. Once that is green, we can validate the dependency through Nextcloud and retire the application-local patch when the fixed vobject release is consumed.

@codecov

codecov Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.66%. Comparing base (0ab3690) to head (e4407cb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #790   +/-   ##
=========================================
  Coverage     98.66%   98.66%           
- Complexity     1748     1757    +9     
=========================================
  Files            71       71           
  Lines          5154     5165   +11     
=========================================
+ Hits           5085     5096   +11     
  Misses           69       69           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SebastianKrupinski
SebastianKrupinski force-pushed the fix/handle-utc-offset-timezones branch 2 times, most recently from 50ca8e5 to 2344ef1 Compare September 14, 2026 17:32
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/handle-utc-offset-timezones branch from 2344ef1 to e4407cb Compare September 14, 2026 17:33
@pi0n00r

pi0n00r commented Sep 14, 2026

Copy link
Copy Markdown

Confirmed: the corrected head is green across PHP 8.2 through 8.5, including Rector and the fixed-offset regression. Thanks for turning this around so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants