Fix negative week numbers in yearly recurrences - #791
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Fixes #621. Its example currently produces December 2028 after March 2026, then December 2030. It also loses the second weekday.
Negative week numbers now count back from the year's final ISO week. The iterator preserves yearly intervals across January and places Sunday at the end of its week. Years without the requested negative week are skipped, with the existing date limit bounding searches.
Eight regression cases fail before this fix. The existing negative-week test also needed its expected dates moved forward one week.
composer phpunitpasses 1,824 tests on PHP 8.2 and 1,825 on PHP 8.5. Both versions passcomposer phpstan. PHP CS Fixer andcomposer rector-checkpass. The example calendar expands to the five expected events through 2030.Both trees report the same 53 PHPUnit test-metadata deprecations.