fix: read base64 encoded values as binary, whatever the property

[odolbeau]

The class of a property comes from its VALUE parameter, or else from its name. PHOTO and LOGO map to Binary, but KEY and SOUND map to FlatText. vCard 2.1 and 3.0 embed keys and sounds in base64 too:

KEY;ENCODING=b;TYPE=PGP:LS0tLS1CRUdJTg==
SOUND;ENCODING=BASE64;TYPE=WAVE:UklGRg==

Such properties are read as text. As a result:

• getValue() returns the base64 string, not the data;
• converting the vCard to 4.0 leaves KEY:LS0tLS1CRUdJTg==, where VCardConverter would otherwise give a data: URI, as it does for PHOTO and LOGO.

Change

In Document::createProperty(), when no VALUE parameter picks the class, an ENCODING parameter of b or BASE64 selects Property\Binary. An explicit VALUE still comes first.

Serialization is unchanged: Binary writes the value back in base64 with its ENCODING parameter.

Not covered: the nameless BASE64 parameter of vCard 2.1 (KEY;BASE64:…). The MIME-dir parser only adds nameless parameters after creating the property, so its class is already chosen.

Tests

tests/VObject/Base64EncodingTest.php covers a vCard 3.0 KEY (value and round trip), a vCard 2.1 SOUND, the conversion to vCard 4.0, and VALUE taking precedence. Three of its tests fail without the fix.

🤖 Generated with Claude Code