prod: Main to Prod Merge #20
Conversation
* chore: added labeler * fix: fix minor issues * chore: testing jobs * chore: updated workflows
* chore: added labeler * fix: fix minor issues * chore: updated ci jobs
* chore: added labeler * fix: fix minor issues * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: update workflows * chore: update workflows --------- Co-authored-by: kushal <kushalmahawar71@gmail.com>
* chore: added labeler * fix: fix minor issues * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: update workflows * chore: update workflows * chore: fix ci jobs * chore: Trigger CI re-run --------- Co-authored-by: kushal <kushalmahawar71@gmail.com>
* feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: fix file name * chore: Trigger CI re-run * fix: updated package json * fix: added eslint * chore(web): run eslint on src and add minimal config * fix : eslint --------- Co-authored-by: Mohit Kumhar <mohitmolela@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR merges the main branch to the production branch, introducing a comprehensive web application implementation for ShieldX alongside server-side authentication capabilities.
- Complete React web application (ShieldX-Web) with authentication, UI screens, and responsive design
- Express.js server with MongoDB integration for user authentication
- Updated CI/CD workflows to support the new web application structure
Reviewed Changes
Copilot reviewed 37 out of 56 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Signup.jsx | File removed from original location |
| src/pages/Login.jsx | File removed from original location |
| ShieldX-Web/* | Complete new React web application with pages, components, and styling |
| server/* | New Express.js backend with authentication routes and MongoDB integration |
| .github/workflows/* | Updated CI/CD workflows to build and test the new web application |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
|
|
||
| <div style={{ textAlign: 'center', marginTop: 12 }}> | ||
| <button className="link" type="button" onClick={() => navigate('/Signup')}>Don't have an account? <span style={{ color: 'red' }}>Sign Up</span></button> |
There was a problem hiding this comment.
The navigation route '/Signup' uses uppercase 'S' but the route is defined as '/signup' (lowercase) in App.jsx. This will cause navigation to fail.
| <button className="link" type="button" onClick={() => navigate('/Signup')}>Don't have an account? <span style={{ color: 'red' }}>Sign Up</span></button> | |
| <button className="link" type="button" onClick={() => navigate('/signup')}>Don't have an account? <span style={{ color: 'red' }}>Sign Up</span></button> |
| - POST /api/signup { name, email, password } | ||
| - POST /api/login { email, password } |
There was a problem hiding this comment.
The API endpoint documentation is inconsistent with the actual implementation. The server uses '/api/register' not '/api/signup', and expects 'username' field, not 'email' field for both endpoints.
| - POST /api/signup { name, email, password } | |
| - POST /api/login { email, password } | |
| - POST /api/register { name, username, password } | |
| - POST /api/login { username, password } |
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>SafeCam Converted Web</title> |
There was a problem hiding this comment.
The page title 'SafeCam Converted Web' doesn't match the application name 'ShieldX' used throughout the codebase.
| <title>SafeCam Converted Web</title> | |
| <title>ShieldX</title> |
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "name": "safe-cam-converted-web", | |||
There was a problem hiding this comment.
The package name 'safe-cam-converted-web' doesn't match the application name 'ShieldX' used throughout the codebase.
| "name": "safe-cam-converted-web", | |
| "name": "shieldx", |
* chore: test * chore: fixes
* chore: test (#10) * chore: added ci jobs (#13) * chore: test (#9) * chore: added labeler * fix: fix minor issues * chore: testing jobs * chore: updated workflows * chore: updated wordflows (#11) * chore: added labeler * fix: fix minor issues * chore: testing jobs * chore: updated workflows * chore: updated ci jobs (#15) * chore: added labeler * fix: fix minor issues * chore: updated ci jobs * chore: update workflows (#17) * chore: added labeler * fix: fix minor issues * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: update workflows * chore: update workflows --------- Co-authored-by: kushal <kushalmahawar71@gmail.com> * chore: updated ci jobs (#18) * chore: added labeler * fix: fix minor issues * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: update workflows * chore: update workflows * chore: fix ci jobs * chore: Trigger CI re-run --------- Co-authored-by: kushal <kushalmahawar71@gmail.com> * Kushal (#19) * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: fix file name * chore: Trigger CI re-run * fix: updated package json * fix: added eslint * chore(web): run eslint on src and add minimal config * fix : eslint --------- Co-authored-by: Mohit Kumhar <mohitmolela@gmail.com> * chore: test (#10) * chore: fix authMiddlewere case-sensitive error * fix: conflicts * feat: Profile Section With All user detail Added * feat: Location Page Updated * fix: fix conflicts 2 --------- Co-authored-by: Mohit Kumhar <mohitmolela@gmail.com>
* chore: test (#10) * chore: added ci jobs (#13) * chore: test (#9) * chore: added labeler * fix: fix minor issues * chore: testing jobs * chore: updated workflows * chore: updated wordflows (#11) * chore: added labeler * fix: fix minor issues * chore: testing jobs * chore: updated workflows * chore: updated ci jobs (#15) * chore: added labeler * fix: fix minor issues * chore: updated ci jobs * chore: update workflows (#17) * chore: added labeler * fix: fix minor issues * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: update workflows * chore: update workflows --------- Co-authored-by: kushal <kushalmahawar71@gmail.com> * chore: updated ci jobs (#18) * chore: added labeler * fix: fix minor issues * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: update workflows * chore: update workflows * chore: fix ci jobs * chore: Trigger CI re-run --------- Co-authored-by: kushal <kushalmahawar71@gmail.com> * Kushal (#19) * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: fix file name * chore: Trigger CI re-run * fix: updated package json * fix: added eslint * chore(web): run eslint on src and add minimal config * fix : eslint --------- Co-authored-by: Mohit Kumhar <mohitmolela@gmail.com> * chore: test (#10) * chore: fix authMiddlewere case-sensitive error * fix: conflicts * feat: Profile Section With All user detail Added * feat: Location Page Updated * fix: fix conflicts 2 * Fix conflicts --------- Co-authored-by: Mohit Kumhar <mohitmolela@gmail.com>
Main to prod