fix: minor fixes in web#23
Merged
Merged
Conversation
* chore: test (#9) * chore: added labeler * fix: fix minor issues * chore: testing jobs * chore: updated workflows
* chore: added labeler * fix: fix minor issues * chore: testing jobs * chore: updated workflows
* chore: added labeler * fix: fix minor issues * chore: updated ci jobs
* chore: added labeler * fix: fix minor issues * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: update workflows * chore: update workflows --------- Co-authored-by: kushal <kushalmahawar71@gmail.com>
* chore: added labeler * fix: fix minor issues * feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: update workflows * chore: update workflows * chore: fix ci jobs * chore: Trigger CI re-run --------- Co-authored-by: kushal <kushalmahawar71@gmail.com>
* feat: #1 Auth Working and complete signup and login Funtionallity * fix : Fix Bugs or error * Fix : Env Variable Hided * Fix * init * chore: fix file name * chore: Trigger CI re-run * fix: updated package json * fix: added eslint * chore(web): run eslint on src and add minimal config * fix : eslint --------- Co-authored-by: Mohit Kumhar <mohitmolela@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a complete backend authentication system with Express.js and MongoDB integration, migrates frontend authentication to use the new backend APIs, and includes various project structure improvements.
- Implements server-side authentication with JWT tokens, bcrypt password hashing, and MongoDB user storage
- Replaces client-side localStorage-only authentication with proper API integration in both login and signup flows
- Updates project structure with proper ESLint configuration, GitHub Actions workflows, and documentation
Reviewed Changes
Copilot reviewed 22 out of 37 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Signup.jsx | Completely removed - old signup component deleted |
| src/pages/Login.jsx | Completely removed - old login component deleted |
| server/test_register.js | Test script for registration and login API endpoints |
| server/src/index.js | Express server setup with CORS, static files, and auth routes |
| server/routes/auth.js | Authentication routes with register, login, and protected endpoints |
| server/package.json | Server dependencies including Express, MongoDB, JWT, and bcrypt |
| server/models/UserR.js | MongoDB user schema with username, password, and name fields |
| server/middleware/authMiddleware.js | JWT authentication middleware for protected routes |
| server/config/db.js | MongoDB connection configuration |
| server/README.md | Documentation for server setup and API endpoints |
| server/.gitignore | Server-specific gitignore for environment files and node_modules |
| ShieldX-Web/src/styles/index.css | Minor CSS update adding justify-content to social button row |
| ShieldX-Web/src/pages/Signup.jsx | New signup component with backend API integration and proper form handling |
| ShieldX-Web/src/pages/Login.jsx | New login component with backend API integration and improved UI |
| ShieldX-Web/src/components/BottomTabs.jsx | Added logout functionality to bottom navigation |
| ShieldX-Web/package.json | Updated dependencies including Vite and ESLint packages |
| ShieldX-Web/eslint.config.cjs | ESLint configuration for React project |
| ShieldX-Web/README.md | Updated documentation with backend integration instructions |
| ShieldX-Web/.gitignore | Frontend gitignore file |
| ShieldX-Web/.eslintrc.json | Alternative ESLint configuration file |
| .github/workflows/lint_test.yml | Updated CI workflow for new project structure |
| .github/workflows/build_test.yml | Updated build workflow with proper directory targeting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 29 out of 41 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mohitkumhar
approved these changes
Sep 25, 2025
ajaynath001
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested?