Skip to content

fix(chart): render chart JSON from json/untagged fences #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sagar-develop merged 1 commit into from
Jun 5, 2026
Merged

fix(chart): render chart JSON from json/untagged fences #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions sample-app/src/main/java/com/nativelm/app/ui/chat/MarkdownText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,14 +293,18 @@ private fun parseMarkdownBlocks(markdown: String): List<MdBlock> {
}
i++ // skip closing fence
val text = body.toString().trimEnd('\n')
if (lang == "chart") {
val spec = ChartParser.parse(text)
// Graceful fallback: a malformed chart shows its data as a code block,
// never an error and never lost content.
out += if (spec != null) MdBlock.Chart(spec) else MdBlock.Code(text)
// Prefer an explicit ```chart fence, but small on-device models routinely
// emit the chart JSON in a ```json (or untagged) block instead — so for those
// we also try to parse it. ChartParser only succeeds on JSON with a recognized
// chart "type" + valid data, so ordinary JSON code samples stay code blocks.
val spec = if (lang == "chart" || lang == "json" || lang.isEmpty()) {
ChartParser.parse(text)
} else {
out += MdBlock.Code(text)
null
}
// Graceful fallback: anything that isn't a valid chart shows as a code block,
// never an error and never lost content.
out += if (spec != null) MdBlock.Chart(spec) else MdBlock.Code(text)
continue
}
line.isBlank() -> flushParagraph()
Expand Down
Loading