Replace Dynaconf with pydantic-settings-driven configuration loading#153
Draft
sagikimhi wants to merge 2 commits into
Draft
Replace Dynaconf with pydantic-settings-driven configuration loading#153sagikimhi wants to merge 2 commits into
sagikimhi wants to merge 2 commits into
Conversation
* feat(socx_tui): improve regression details, support saving/loading state * fix(socx_tui): fix header and footer panel colors Signed-off-by: Sagi Kimhi <sagi.kim5@gmail.com> * chore(.gitignore): ignore regression dumps Signed-off-by: Sagi Kimhi <sagi.kim5@gmail.com> * chore: bump version to 0.13.3 Signed-off-by: Sagi Kimhi <sagi.kim5@gmail.com> --------- Signed-off-by: Sagi Kimhi <sagi.kim5@gmail.com>
9cd4df6 to
a9c83ab
Compare
ad49eab to
5b9edc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dynaconfand rely on a lighter, explicit configuration stack that usespydantic-settingsfor env-aware values andpython-boxfor nested/dotted access and serialisation.settingsaccess patterns across the codebase.Description
dynaconffrom runtime dependencies and updated README/pyproject.tomlto reflect the new stack (pydantic-settings+python-box).Settingswith a newSettingsimplementation insrc/socx/config/_settings.pythat usesbox.Boxfor in-memory mapping,pydantic-settingsfor environment integration (SettingsEnv), supportssettings_file/preload, load history,load_file(YAML/JSON/TOML), and@jinjatemplate resolution.src/socx/config/_config.pyto use the newensure_a_listandSettingsclass and preserved the LocalProxysettingsbehavior and user/local override loading flow.Settingstype andbox.Box(src/socx/config/serializers.py,src/socx/config/encoders.py,src/socx/config/validators.py).src/socx/config/converters.py(introduces a lightweightLazyshim and internal converter registry) and migrated callers (e.g.,src/socx_plugins/git/summary.py) to use the new converters/API.DynaBoxwithbox.Box, replaced Dynaconf file helpers with stdlib equivalents (e.g.,glob) and local dedupe logic insrc/socx_plugins/git/utils.py, and updated config CLI/history rendering to usebox.Box.Testing
python -m compileall src/socx/config src/socx_plugins/git src/socx_plugins/config, which completed successfully.PYTHONPATH=src python -m pytest tests/test_regression_loading.py -q, but test execution could not complete in this environment because package metadata forsocx-cliis not installed (importlib.metadata.PackageNotFoundError), so full pytest validation was not possible here.Codex Task