Repository navigation
Remove unused rank-bm25 dependency, fix hybrid-search phrasing - #3
Merged
Merged
Conversation
rank-bm25 was in requirements.txt but never imported anywhere in the codebase. Retrieval blends vector similarity with recency decay, not keyword search, so the README's "hybrid search" phrasing overstated what retrieve/ actually does — reworded to be explicit that there's no BM25/keyword component.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during a cross-repo audit:
rank-bm25was listed inrequirements.txtbut never imported anywhere in the codebase — dead dependency. Also, the README described retrieval as "hybrid search," which normally implies keyword + vector — but there's no BM25/keyword component here, only vector similarity blended with a recency-decay weight. Reworded to say that explicitly instead of overstating it.Verified: fresh venv,
pip install -r requirements-dev.txt && pytest— 34/34 pass without the removed dependency.