post: finishing waves in SignalK's Open-Meteo plugin#22
Open
clarkbw wants to merge 1 commit into
Open
Conversation
The commented-out marine code was unfinished, not broken — and we'd already built the weather-mcp consumer for water.* before the producer existed. Chesterton's fence, the throttling history, the SI-period bug, and closing the loop upstream instead of forking. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New engineering post: The commented-out code was a to-do, not a bug — finishing waves in SignalK's Open-Meteo plugin.
Story behind openmeteo-provider-plugin#7: our weather-mcp SignalK provider already read
water.*, but the field came back empty because the upstream plugin's marine query was commented out. Rather than fork, we finished the producer. Covers the Chesterton's-fence dig (unfinished vs. broken), the Open-Meteo throttling history, the SI-period bug hiding in the disabled draft, and how one upstream PR lit up a code path we'd already shipped — adopt-before-build at the API seam.~1,150 words. Verified-live
waterJSON included.🤖 Generated with Claude Code