Skip to content

Fix language origins, trade answers, and update reading resources - #100

Merged
githubSINGLE merged 23 commits into
mainfrom
opensource
Aug 5, 2026
Merged

Fix language origins, trade answers, and update reading resources#100
githubSINGLE merged 23 commits into
mainfrom
opensource

Conversation

@githubSINGLE

Copy link
Copy Markdown
Collaborator

No description provided.

lake0000 and others added 23 commits July 14, 2026 17:28
- 依据「八月高频表格(2).xlsx」的「八月高频文章」本月频次更新 85 条 frequency
- A 组(在八月表内不一致)更新为八月本月频次;B 组按「全部文章」表频率;C 组(疑似过度标注)改为 low
- examId 保持不变;同步重建 core-foundation.bundle.js
1.升级v2数据层
2. 草稿与提交后注释持久化
3. 阅读显示控制
@githubSINGLE

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a11fa4a9c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread js/data/v2/dataKernel.js
Comment on lines +28 to +31
const LEGACY_UNPREFIXED_WEB_KEYS = Object.freeze([
'practice_records',
'vocab_user_config',
'user_achievements'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Migrate the old unprefixed preference keys

When upgrading an existing browser profile, readLegacyValues() only imports unprefixed localStorage entries named in this allowlist. The pre-v2 code wrote several user-facing preferences under other unprefixed keys (ielts_reading_candidate_code_preferences_v1, ielts_reading_timer_preferences_v2, ielts_listening_timer_preferences_v1, and the suite_* keys), so they are discarded before the preference migration can see them. Users who customized candidate ID, timers, or suite mode will silently revert to defaults on first v2 boot; add those keys and normalize their shapes into preferences.values during migration.

Useful? React with 👍 / 👎.

"q10",
"q11"
],
"bodyHtml": "<div class=\"group\" id=\"q10-11-anchor\">\n<h4>Questions 23 and 24</h4>\n<p>Choose <strong>TWO</strong> letters, A–E.</p>\n<p>Write the correct letters in boxes 23 and 24 on your answer sheet.</p>\n<p>Which <strong>TWO</strong> of the following problems are stated as being linked with the internal ‘clock’?</p>\n<div class=\"checkbox-options\" data-group=\"q10_11\" data-limit=\"2\">\n<label><input type=\"checkbox\" name=\"q10_11\" value=\"A\"> A\ta decrease in output in workplaces without windows to let in natural light</label>\n<label><input type=\"checkbox\" name=\"q10_11\" value=\"B\"> B\ta failure among workers on night-shifts to perform tasks</label>\n<label><input type=\"checkbox\" name=\"q10_11\" value=\"C\"> C\tan increase in casualties on the roads at specific times of day</label>\n<label><input type=\"checkbox\" name=\"q10_11\" value=\"D\"> D\ta decline in efficiency on certain days in a number of fixed cycles</label>\n<label><input type=\"checkbox\" name=\"q10_11\" value=\"E\"> E\ta rise in mood swings dependent on the appearance of the Sun</label>\n</div>\n</div>",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the trailing comma from exam payloads

This generated object is parsed as strict JSON by developer/tests/ci/check_reading_data_integrity.py; the trailing comma after bodyHtml makes json.loads() abort with Illegal trailing comma, so the reading data integrity/release check fails before validating the dataset. Remove this comma or emit strict JSON for generated exam payloads; the same trailing-property pattern also appears in p3-high-173.js.

Useful? React with 👍 / 👎.

@githubSINGLE
githubSINGLE merged commit c2a5bc1 into main Aug 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants