Skip to content

Fix handling of GeneralNames and basicConstraints in x509_v2 - #70047

Open
lkubb wants to merge 5 commits into
saltstack:3006.xfrom
lkubb:fix-x509v2-nameconstraints
Open

Fix handling of GeneralNames and basicConstraints in x509_v2#70047
lkubb wants to merge 5 commits into
saltstack:3006.xfrom
lkubb:fix-x509v2-nameconstraints

Conversation

@lkubb

@lkubb lkubb commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Applies GeneralName specs more correctly
  • Accounts for issuer cert's pathlen when adding basicConstraints
  • Respects get_encoding in salt.utils.x509.load_pubkey

What issues does this PR fix or reference?

Fixes: #70041
Fixes: #70042
Fixes: #70046

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@lkubb
lkubb requested a review from a team as a code owner August 14, 2026 15:20
@lkubb lkubb changed the title Fix handling of specific x509_v2 GeneralNames Fix handling of some GeneralNames and basicConstraints Aug 14, 2026
@lkubb lkubb changed the title Fix handling of some GeneralNames and basicConstraints Fix handling of GeneralNames and basicConstraints in x509_v2 Aug 14, 2026
@lkubb
lkubb force-pushed the fix-x509v2-nameconstraints branch from 2f499f5 to b82635c Compare August 14, 2026 15:25
@lkubb
lkubb force-pushed the fix-x509v2-nameconstraints branch from b82635c to 7356493 Compare August 14, 2026 15:26
@lkubb
lkubb force-pushed the fix-x509v2-nameconstraints branch from 7356493 to b82635c Compare August 14, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants