Security: lock /setup after owner account is created#86
Open
vdaluz wants to merge 1 commit intosam1am:mainfrom
Open
Security: lock /setup after owner account is created#86vdaluz wants to merge 1 commit intosam1am:mainfrom
vdaluz wants to merge 1 commit intosam1am:mainfrom
Conversation
/setup and /auth/setup are currently accessible even after the owner account exists. Any visitor can hit /setup at any time, which is surprising and potentially confusing (though account creation itself is already guarded in the route handler). Moving the guard to the middleware layer makes the protection consistent and ensures it applies regardless of how the route handler evolves. After the first account is created, both endpoints redirect to /login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/setupand/auth/setupare accessible to anyone at any time, even after the owner account already exists. The route handler does guard against duplicate account creation, but the endpoint itself remains open indefinitely.Fix
Moves the guard to the middleware layer so both endpoints return a redirect to
/loginas soon as a user account exists. This is more robust than relying solely on the route handler — it protects against future changes and makes the intent explicit at the routing level.The check uses the existing
user_exists()helper that is already imported in the middleware.