Fix API submit route exception - Remove random error simulation - #12
Open
sameelarif wants to merge 1 commit into
Open
Fix API submit route exception - Remove random error simulation#12sameelarif wants to merge 1 commit into
sameelarif wants to merge 1 commit into
Conversation
- Remove random error simulation that was causing unpredictable 500 status responses - Add proper email validation with regex pattern - Improve error handling in processUserData function with deterministic validation - Replace random 30% failure rate with proper input validation - Enhanced error responses with specific error messages instead of generic exceptions - Add comprehensive input validation for name length and email format Fixes the random 500 errors that were occurring in POST /api/submit endpoint. The previous code had random error simulation that would cause failures 30% of the time, which has been replaced with proper validation and error handling. Co-authored-by: openhands <openhands@all-hands.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/api/submitendpoint was experiencing random 500 status errors due to intentional error simulation code that would fail 30% of the time. This was causing unpredictable failures in form submissions.Root Cause
The
processUserDatafunction contained random error simulation:This was originally intended for testing error monitoring systems but was causing production issues.
Solution
This PR implements a comprehensive fix:
✅ Changes Made
🔧 Technical Details
/^[^\s@]+@[^\s@]+\.[^\s@]+$/🧪 Testing
The fix addresses the specific error mentioned in the logs:
📝 Related Issues
/api/submitImpact
@sameelarif can click here to continue refining the PR