added docker executor support#29
Closed
digitalLumberjack wants to merge 1 commit into
Closed
Conversation
You can use the docker executor by using `RUNNER_EXECUTOR=docker`. You must provide a docker image to use in `RUNNER_DOCKER_IMAGE` (e.g. docker:latest) If `RUNNER_DOCKER_MODE` is set to `socket`, the docker socket is shared between the runner and the build container. If it is not, you must use docker in docker service in your .gitlabci.yml definitions. See https://docs.gitlab.com/ce/ci/docker/using_docker_build.html for more info.
|
This sounds good but I have to admit it's been a while since I've looked at this stuff. Would you mind letting me know if it supersedes this PR I created #19. If so I'll close it. |
|
I'm using this on my own fork (combined with #31 for version 1.8.0) and it works great. Would be good to see it merged in. |
|
I'm referencing my fork here which support docker in docker, based on alpine, ENV_VARS support inside dind and support for rancher-compose. There is a DNS change to support rancher-compose that will be removed when gitlab will supports docker labels. Link to the diff: 39274ea...oomathias:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can use the docker executor by using
RUNNER_EXECUTOR=docker. You must provide a docker image to use inRUNNER_DOCKER_IMAGE(e.g. docker:latest)If
RUNNER_DOCKER_MODEis set tosocket, the docker socket is shared between the runner and the build container. If it is not, you must use docker in docker service in your .gitlabci.yml definitions.See https://docs.gitlab.com/ce/ci/docker/using_docker_build.html for more info.