-
-
Notifications
You must be signed in to change notification settings - Fork 53
Add separate_type variable in form #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@harrymkt also, this is very nice, but as a user myself using nvgt, would you please make it true by default instead of false, to keep compatibility and behave like before for everyone on there forms, may be someone don't want this to be changed in their form, and if someone want the new way, they know that this option exists, and they can change it to false or true for their project, as they wish. Thanks! |
|
@amirmahdifard, I'm not good with the knowledge related to selection code. |
|
@harrymkt Thanks for setting to true by default. Personally I would set it to false for my self, but I suggested true by default so it's won't suddenly changed for everyone even those who don't want it so they have to manually change it to true again for them selves. What about the issues of go to line dialog? can you fix that? sorry for asking! |
|
Please, if you have any bugs with form just open a new issue or pull request rather than asking in pull requests for fixes which are unrelated to the pr itself. Just my viewpoint, but for example in a new issue it can be handled more aporpriately and it isn't being overlooked by others who might are able to fix it. |
|
Please move bugs not relevant to this PR to another issue (but please check for a prior open issue if one exists). |
|
why this isn't merged yet? |
This alternates between the main one which is the type and caption are always speak separately. By setting this to false, you can create similar to actual forms.
Remember, actual form does not - speak type and caption separately. It does not speak like, username edit, then another speech Jon. Instead, it speaks like, username edit Jon.
I hope this explanation makes sence, so as consider this pull request.